U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] arm64: booti: allow to place kernel image anywhere in physical memory
Date: Tue, 7 Mar 2017 11:43:52 +0000	[thread overview]
Message-ID: <20170307114352.GA24550@leverpostej> (raw)
In-Reply-To: <20170228171509.GL20531@bill-the-cat>

On Tue, Feb 28, 2017 at 12:15:09PM -0500, Tom Rini wrote:
> On Wed, Mar 01, 2017 at 02:03:58AM +0900, Masahiro Yamada wrote:
> > 2017-02-27 7:41 GMT+09:00 Tom Rini <trini@konsulko.com>:
> > > On Thu, Feb 23, 2017 at 10:31:17AM -0500, Tom Rini wrote:

> > > c) I'm not convinced your math above is correct.  images->ep is where we
> > > were put in memory.  This is what we should make sure is 2MiB aligned,
> > > and then add to it the text_offset.  And some quick testing with
> > > CONFIG_ARM64_RANDOMIZE_TEXT_OFFSET enabled Images :)
> > 
> > My intention is
> > 
> >   images->ep  =  (2MiB aligned base)  + text_offset
> > 
> > If this equation is met, the image is already placed at the bootable position.
> > We can skip the relocation.
> > 
> > Theoretically, we can not know the value of text_offset in advance
> > (especially for CONFIG_ARM64_RANDOMIZE_TEXT_OFFSET).
> > However, in practice, we know text_offset is 0x80000.

Per the arm64 Image header, no particular value  of text_offset should
be assumed. Please do not assume a particular value

It has always been the intent that bootloaders should read this, though
this evidently wasn't very clear (and the bootwrapper set a bad
example). I tried to clear this up with documentation updates (and the
addition of ARM64_RANDOMIZE_TEXT_OFFSET).

> > If we put the image at 2MiB aligned base, the relocation would
> > always happen.
> 
> Correct.  But I honestly don't know if non-randomized text offset is the
> common case people will optimize for or randomized for added security will be
> the more common case.  

FWIW, the randomized text_offset is a bootloader debugging/testing
feature, and there's no security aspect to it.

It was added [1] as an additional to hint to bootloader authors that
they must respect the text_offset field.

Thanks,
Mark.

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=da57a369d3bc5cd61db90f7e9555840381db9b09

  reply	other threads:[~2017-03-07 11:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22  2:34 [U-Boot] [PATCH 1/2] arm64: booti: update "res1" field to "flags" Masahiro Yamada
2017-02-22  2:34 ` [U-Boot] [PATCH 2/2] arm64: booti: allow to place kernel image anywhere in physical memory Masahiro Yamada
2017-02-22 16:19   ` Tom Rini
2017-02-23  9:17     ` Masahiro Yamada
2017-02-23 15:31       ` Tom Rini
2017-02-26 22:41         ` Tom Rini
2017-02-28 17:03           ` Masahiro Yamada
2017-02-28 17:15             ` Tom Rini
2017-03-07 11:43               ` Mark Rutland [this message]
2017-03-07 12:16                 ` Tom Rini
2017-03-07 13:54                   ` Mark Rutland
2017-03-07 14:12                     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170307114352.GA24550@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox