public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: Update our 'ret' assembler macro slightly
Date: Tue, 7 Mar 2017 21:59:41 +0100	[thread overview]
Message-ID: <20170307215941.113a4c5b@lilith> (raw)
In-Reply-To: <1488466770-6323-1-git-send-email-trini@konsulko.com>

Hello Tom,

LGTM.

On Thu,  2 Mar 2017 09:59:30 -0500, Tom Rini <trini@konsulko.com> wrote:
> We only support cores that do Thumb-1 or later.  So we add a comment to
> explain this and remove the architecture test.
> 
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Cc: Mans Rullgard <mans@mansr.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  arch/arm/include/asm/assembler.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/include/asm/assembler.h b/arch/arm/include/asm/assembler.h
> index c56daf2a1f69..d24be2d484fe 100644
> --- a/arch/arm/include/asm/assembler.h
> +++ b/arch/arm/include/asm/assembler.h
> @@ -57,17 +57,17 @@
>  #define PLD(code...)
>  #endif
>  
> +/*
> + * We only support cores that support at least Thumb-1 and thus we use
> + * 'bx lr'
> + */
>  	.irp	c,,eq,ne,cs,cc,mi,pl,vs,vc,hi,ls,ge,lt,gt,le,hs,lo
>  	.macro	ret\c, reg
> -#if defined(__ARM_ARCH_5E__)
> -	mov\c	pc, \reg
> -#else
>  	.ifeqs	"\reg", "lr"
>  	bx\c	\reg
>  	.else
>  	mov\c	pc, \reg
>  	.endif
> -#endif
>  	.endm
>  	.endr
>  
> -- 
> 1.9.1
> 



Amicalement,
-- 
Albert.

  reply	other threads:[~2017-03-07 20:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02 14:59 [U-Boot] [PATCH] arm: Update our 'ret' assembler macro slightly Tom Rini
2017-03-07 20:59 ` Albert ARIBAUD [this message]
2017-03-07 21:47 ` Vikas MANOCHA
2017-03-18  0:16 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170307215941.113a4c5b@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox