[U-Boot] [PATCH] ti_armv7_common: env: Use args_mmc in FIT loading path

[U-Boot] [PATCH] ti_armv7_common: env: Use args_mmc in FIT loading path

[Andrew F. Davis]

The env command 'args_fit' does not define a root path, this forces us to
embed the rootfs into the FIT image. FIT images do not need to contain a
rootfs, when they do not the kernel will fall-back to the kernel argument
'root', if this is not defined the kernel will not boot. It is safe to
add this as when we do have the rootfs in FIT this argument is ignored.
As 'loadfit' is only called from the MMC boot path, use 'args_mmc' to
correctly populate 'bootargs'.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 include/configs/ti_armv7_common.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
index d7ad13570e..c7c83afa4e 100644
--- a/include/configs/ti_armv7_common.h
+++ b/include/configs/ti_armv7_common.h
@@ -117,8 +117,7 @@
 	"fit_loadaddr=0x88000000\0" \
 	"fit_bootfile=fitImage\0" \
 	"update_to_fit=setenv loadaddr ${fit_loadaddr}; setenv bootfile ${fit_bootfile}\0" \
-	"args_fit=setenv bootargs console=${console} \0" \
-	"loadfit=run args_fit; bootm ${loadaddr}#${fdtfile};\0" \
+	"loadfit=run args_mmc; bootm ${loadaddr}#${fdtfile};\0" \
 
 /*
  * DDR information.  If the CONFIG_NR_DRAM_BANKS is not defined,
-- 
2.11.0

[U-Boot] [PATCH] ti_armv7_common: env: Use args_mmc in FIT loading path

[Lokesh Vutla]

On Saturday 11 March 2017 03:23 AM, Andrew F. Davis wrote:
> The env command 'args_fit' does not define a root path, this forces us to
> embed the rootfs into the FIT image. FIT images do not need to contain a
> rootfs, when they do not the kernel will fall-back to the kernel argument
> 'root', if this is not defined the kernel will not boot. It is safe to
> add this as when we do have the rootfs in FIT this argument is ignored.
> As 'loadfit' is only called from the MMC boot path, use 'args_mmc' to
> correctly populate 'bootargs'.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>

Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh

[U-Boot] [PATCH] ti_armv7_common: env: Use args_mmc in FIT loading path

[Andrew F. Davis]

The env command 'args_fit' does not define a root path, this forces us to
embed the rootfs into the FIT image. FIT images do not need to contain a
rootfs, when they do not the kernel will fall-back to the kernel argument
'root', if this is not defined the kernel will not boot. It is safe to
add this as when we do have the rootfs in FIT this argument is ignored.
As 'loadfit' is only called from the MMC boot path, use 'args_mmc' to
correctly populate 'bootargs'.

Signed-off-by: Andrew F. Davis <afd@ti.com>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 include/configs/ti_armv7_common.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
index a4ec4ce00a..b2950efd47 100644
--- a/include/configs/ti_armv7_common.h
+++ b/include/configs/ti_armv7_common.h
@@ -117,8 +117,7 @@
 	"fit_loadaddr=0x88000000\0" \
 	"fit_bootfile=fitImage.itb\0" \
 	"update_to_fit=setenv loadaddr ${fit_loadaddr}; setenv bootfile ${fit_bootfile}\0" \
-	"args_fit=setenv bootargs console=${console} \0" \
-	"loadfit=run args_fit; bootm ${loadaddr}#${fdtfile};\0" \
+	"loadfit=run args_mmc; bootm ${loadaddr}#${fdtfile};\0" \
 
 /*
  * DDR information.  If the CONFIG_NR_DRAM_BANKS is not defined,
-- 
2.11.0

[U-Boot] ti_armv7_common: env: Use args_mmc in FIT loading path

[Tom Rini]

On Fri, Mar 10, 2017 at 03:53:54PM -0600, Andrew F. Davis wrote:

> The env command 'args_fit' does not define a root path, this forces us to
> embed the rootfs into the FIT image. FIT images do not need to contain a
> rootfs, when they do not the kernel will fall-back to the kernel argument
> 'root', if this is not defined the kernel will not boot. It is safe to
> add this as when we do have the rootfs in FIT this argument is ignored.
> As 'loadfit' is only called from the MMC boot path, use 'args_mmc' to
> correctly populate 'bootargs'.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170408/9c4bb2d1/attachment.sig>