From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Pass empty CFLAGS on invocation of libfdt/setup.py
Date: Thu, 16 Mar 2017 17:11:55 -0400 [thread overview]
Message-ID: <20170316211155.GO19897@bill-the-cat> (raw)
In-Reply-To: <1489689480-23775-1-git-send-email-jcmvbkbc@gmail.com>
On Thu, Mar 16, 2017 at 11:38:00AM -0700, Max Filippov wrote:
> When building u-boot tools in cross-build environment CFLAGS environment
> variable set up for target is taken into an account when building code
> for host. Set it to empty on invocation of python.
>
> This fixes the following build errors when cross-compiling for xtensa:
>
> cc1: error: unrecognized command line option "-mlongcalls"
> cc1: error: unrecognized command line option "-mauto-litpools"
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> tools/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index 1c840d7..c224e8a 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -120,7 +120,7 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS)
> libfdt:
>
> tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c
> - LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \
> + LDFLAGS="$(HOSTLDFLAGS)" CFLAGS="" python $(srctree)/lib/libfdt/setup.py \
I think we need to be passing in HOSTCFLAGS or we'll end up being broken
on certain other cases (which are broken today I suspect). Can you test
that out? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170316/4d52fc2b/attachment.sig>
next prev parent reply other threads:[~2017-03-16 21:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 18:38 [U-Boot] [PATCH] Pass empty CFLAGS on invocation of libfdt/setup.py Max Filippov
2017-03-16 21:11 ` Tom Rini [this message]
2017-03-16 21:56 ` Max Filippov
2017-03-16 22:06 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316211155.GO19897@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox