* [U-Boot] [PATCH] mmc: xenon_sdhci: Add missing host->max_clk to Xenon SDHCI driver
@ 2017-03-20 16:00 ` Stefan Roese
2017-03-21 12:07 ` Jaehoon Chung
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Roese @ 2017-03-20 16:00 UTC (permalink / raw)
To: u-boot
The Xenon SDHCI driver just missed the integration of this patch:
git ID 6d0e34bf
mmc: sdhci: Distinguish between base clock and maximum peripheral frequency
With this patch applied, the SDHCI subsystem complains now with this warning
while probing:
sdhci_setup_cfg: Hardware doesn't specify base clock frequency
This patch fixes this issue, by providing the missing host->max_clk
variable to the SDHCI subsystem.
Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Hu Ziji <huziji@marvell.com>
Cc: Victor Gu <xigu@marvell.com>
Cc: Konstantin Porotchkin <kostap@marvell.com>
Cc: Nadav Haklai <nadavh@marvell.com>
Cc: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/mmc/xenon_sdhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/xenon_sdhci.c b/drivers/mmc/xenon_sdhci.c
index f678110239..2a0d8b46c6 100644
--- a/drivers/mmc/xenon_sdhci.c
+++ b/drivers/mmc/xenon_sdhci.c
@@ -422,7 +422,8 @@ static int xenon_sdhci_probe(struct udevice *dev)
host->ops = &xenon_sdhci_ops;
- ret = sdhci_setup_cfg(&plat->cfg, host, XENON_MMC_MAX_CLK, 0);
+ host->max_clk = XENON_MMC_MAX_CLK;
+ ret = sdhci_setup_cfg(&plat->cfg, host, 0, 0);
if (ret)
return ret;
--
2.12.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] mmc: xenon_sdhci: Add missing host->max_clk to Xenon SDHCI driver
2017-03-20 16:00 ` [U-Boot] [PATCH] mmc: xenon_sdhci: Add missing host->max_clk to Xenon SDHCI driver Stefan Roese
@ 2017-03-21 12:07 ` Jaehoon Chung
0 siblings, 0 replies; 2+ messages in thread
From: Jaehoon Chung @ 2017-03-21 12:07 UTC (permalink / raw)
To: u-boot
Hi Stefan,
On 03/21/2017 01:00 AM, Stefan Roese wrote:
> The Xenon SDHCI driver just missed the integration of this patch:
>
> git ID 6d0e34bf
> mmc: sdhci: Distinguish between base clock and maximum peripheral frequency
>
> With this patch applied, the SDHCI subsystem complains now with this warning
> while probing:
>
> sdhci_setup_cfg: Hardware doesn't specify base clock frequency
>
> This patch fixes this issue, by providing the missing host->max_clk
> variable to the SDHCI subsystem.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Hu Ziji <huziji@marvell.com>
> Cc: Victor Gu <xigu@marvell.com>
> Cc: Konstantin Porotchkin <kostap@marvell.com>
> Cc: Nadav Haklai <nadavh@marvell.com>
> Cc: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
Applied on u-boot-mmc. Thanks!
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/xenon_sdhci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/xenon_sdhci.c b/drivers/mmc/xenon_sdhci.c
> index f678110239..2a0d8b46c6 100644
> --- a/drivers/mmc/xenon_sdhci.c
> +++ b/drivers/mmc/xenon_sdhci.c
> @@ -422,7 +422,8 @@ static int xenon_sdhci_probe(struct udevice *dev)
>
> host->ops = &xenon_sdhci_ops;
>
> - ret = sdhci_setup_cfg(&plat->cfg, host, XENON_MMC_MAX_CLK, 0);
> + host->max_clk = XENON_MMC_MAX_CLK;
> + ret = sdhci_setup_cfg(&plat->cfg, host, 0, 0);
> if (ret)
> return ret;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-21 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170320160042epcas4p3196ad2288f16f88c79f659b01df3cd7b@epcas4p3.samsung.com>
2017-03-20 16:00 ` [U-Boot] [PATCH] mmc: xenon_sdhci: Add missing host->max_clk to Xenon SDHCI driver Stefan Roese
2017-03-21 12:07 ` Jaehoon Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox