From: "Martin Hundebøll" <mnhu@prevas.dk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] part_iso: Cache align read buffer
Date: Wed, 22 Mar 2017 14:43:24 +0100 [thread overview]
Message-ID: <20170322134324.27189-1-mnhu@prevas.dk> (raw)
The global 'tmpbuf' variable in part_iso triggers invalid cache
alignment warnings when not being aligned to ARCH_DMA_MINALIGN:
ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x4ffbb6ac
ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0x4ffbbeac
The quick fix here is to align the global 'tmpbuf' variable using
DEFINE_CACHE_ALIGN_BUFFER. A real fix would be to change part_iso.c to
use function local buffers defined with ALLOC_CACHE_ALIGN_BUFFER.
Signed-off-by: Martin Hundebøll <mnhu@prevas.dk>
---
disk/part_iso.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/disk/part_iso.c b/disk/part_iso.c
index bb8ed658f2..970a27bf67 100644
--- a/disk/part_iso.c
+++ b/disk/part_iso.c
@@ -8,6 +8,7 @@
#include <common.h>
#include <command.h>
#include <asm/unaligned.h>
+#include <memalign.h>
#include "part_iso.h"
#ifdef HAVE_BLOCK_DEVICE
@@ -24,7 +25,7 @@
#undef CHECK_FOR_POWERPC_PLATTFORM
#define CD_SECTSIZE 2048
-static unsigned char tmpbuf[CD_SECTSIZE];
+DEFINE_CACHE_ALIGN_BUFFER(unsigned char, tmpbuf, CD_SECTSIZE);
unsigned long iso_dread(struct blk_desc *block_dev, lbaint_t start,
lbaint_t blkcnt, void *buffer)
--
2.12.0
next reply other threads:[~2017-03-22 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 13:43 Martin Hundebøll [this message]
2017-03-22 14:50 ` [U-Boot] [PATCH] part_iso: Cache align read buffer Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322134324.27189-1-mnhu@prevas.dk \
--to=mnhu@prevas.dk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox