From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 01/17] board_f: sandbox: Move setup_ram_buf() to private code
Date: Thu, 6 Apr 2017 12:47:06 -0400 [thread overview]
Message-ID: <20170406164706.GD19897@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ1xeP5J4Y2q4fB8uvtnExwfxEcy+gymc-sc0rywP1K2EA@mail.gmail.com>
On Thu, Apr 06, 2017 at 10:43:38AM -0600, Simon Glass wrote:
> Hi Tom,
>
> On 6 April 2017 at 10:27, Tom Rini <trini@konsulko.com> wrote:
> > On Thu, Apr 06, 2017 at 10:24:09AM -0600, Simon Glass wrote:
> >> Hi Tom,
> >>
> >> On 6 April 2017 at 10:23, Tom Rini <trini@konsulko.com> wrote:
> >> > On Tue, Mar 28, 2017 at 10:27:16AM -0600, Simon Glass wrote:
> >> >
> >> >> There is no need to have this call in the generic init sequence and no
> >> >> other architecture has needed it in the time it has been there. Move it
> >> >> into sandbox's private code.
> >> >>
> >> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >> >> Reviewed-by: Stefan Roese <sr@denx.de>
> >> >> Reviewed-by: Stefan Roese <sr@denx.de>
> >> >
> >> > Applied to u-boot/master, thanks!
> >>
> >> I was just about to resend that series to fix the cover letter...but
> >> perhaps it doesn't matter.
> >>
> >> I'm resending the second series now.
> >
> > Yeah, you'll want to re-sync stuff, sorry. I did have a few fixups to
> > do as I applied these, but mainly due to removing
> > sparc/blackfin/openrisc first.
>
> Yes I was assuming the removal would go in before my series, so that's
> good. I think you've applied everything except this patch:
>
> board_f: Rename initdram() to dram_init()
>
> Is that right? If so, I'll respin and resend. I hope it wasn't too much work!
Correct, and it wasn't hard, no. But with initdram() what I was trying
to stress yesterday was that we have some use cases where both functions
are used and in different ways. So some of the platforms will need a
real think on how to get the same functionality still. I'm not sure if
I was clear enough yesterday. Thanks again!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170406/51544157/attachment.sig>
next prev parent reply other threads:[~2017-04-06 16:47 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 16:27 [U-Boot] [PATCH 01/17] board_f: sandbox: Move setup_ram_buf() to private code Simon Glass
2017-03-28 16:27 ` [U-Boot] [PATCH 02/17] board_f: initcall: Add a header guard Simon Glass
2017-04-06 16:23 ` [U-Boot] [U-Boot,02/17] " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 03/17] board_f: x86: Rename x86_fsp_init() to arch_fsp_init() Simon Glass
2017-03-29 5:09 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 04/17] board_f: powerpc: Join the two CONFIG_8xx_CPUCLK_DEFAULT sections Simon Glass
2017-03-29 5:12 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 05/17] board_f: powerpc: Rename get_clocks_866() to get_clocks() Simon Glass
2017-03-28 20:08 ` york sun
2017-03-29 5:12 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 06/17] board_f: Remove sdram_adjust_866() from the init sequence Simon Glass
2017-03-29 5:13 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 07/17] board_f: Remove adjust_sdram_tbs_8xx() " Simon Glass
2017-03-29 5:14 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 08/17] board_f: powerpc: Unified get_clocks() portion of " Simon Glass
2017-03-28 20:08 ` york sun
2017-03-29 5:15 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 09/17] board_f: powerpc: Use timer_init() instead of init_timebase() Simon Glass
2017-03-28 20:08 ` york sun
2017-03-29 5:16 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 10/17] board_f: Use timer_init() on all archs Simon Glass
2017-03-28 20:08 ` york sun
2017-03-29 5:18 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot,10/17] " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 11/17] powerpc: freescale: Unify the two get_clocks() calls Simon Glass
2017-03-28 17:10 ` york sun
2017-03-28 20:08 ` york sun
2017-03-29 5:19 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 12/17] board_f: powerpc: Move prt_83xx_rsr() to private code Simon Glass
2017-03-29 5:19 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 13/17] board_f: sandbox: Move sandbox_early_getopt_check() into misc_init_f() Simon Glass
2017-03-29 5:20 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 14/17] board_f: powerpc: Make prt_8260_rsr(), prt_8260_clks() private Simon Glass
2017-03-29 5:21 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 15/17] board_f: x86: Use checkcpu() for CPU init Simon Glass
2017-03-29 5:22 ` Stefan Roese
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 16/17] i2c: Drop unused i2c_soft...() functions Simon Glass
2017-04-06 16:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-03-28 16:27 ` [U-Boot] [PATCH 17/17] i2c: Drop CONFIG_SOFT_I2C_MULTI_BUS Simon Glass
2017-03-29 8:41 ` Lukasz Majewski
2017-03-30 4:40 ` Jaehoon Chung
2017-04-06 16:25 ` [U-Boot] [U-Boot,17/17] " Tom Rini
2017-03-29 5:01 ` [U-Boot] [PATCH 01/17] board_f: sandbox: Move setup_ram_buf() to private code Stefan Roese
2017-04-06 16:23 ` [U-Boot] [U-Boot, " Tom Rini
2017-04-06 16:24 ` Simon Glass
2017-04-06 16:27 ` Tom Rini
2017-04-06 16:43 ` Simon Glass
2017-04-06 16:47 ` Tom Rini [this message]
2017-04-06 16:50 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406164706.GD19897@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox