* [U-Boot] [PATCH] ti_armv7_common: env: Use args_mmc in FIT loading path
@ 2017-03-10 21:53 Andrew F. Davis
2017-03-13 4:05 ` Lokesh Vutla
0 siblings, 1 reply; 3+ messages in thread
From: Andrew F. Davis @ 2017-03-10 21:53 UTC (permalink / raw)
To: u-boot
The env command 'args_fit' does not define a root path, this forces us to
embed the rootfs into the FIT image. FIT images do not need to contain a
rootfs, when they do not the kernel will fall-back to the kernel argument
'root', if this is not defined the kernel will not boot. It is safe to
add this as when we do have the rootfs in FIT this argument is ignored.
As 'loadfit' is only called from the MMC boot path, use 'args_mmc' to
correctly populate 'bootargs'.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
include/configs/ti_armv7_common.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
index d7ad13570e..c7c83afa4e 100644
--- a/include/configs/ti_armv7_common.h
+++ b/include/configs/ti_armv7_common.h
@@ -117,8 +117,7 @@
"fit_loadaddr=0x88000000\0" \
"fit_bootfile=fitImage\0" \
"update_to_fit=setenv loadaddr ${fit_loadaddr}; setenv bootfile ${fit_bootfile}\0" \
- "args_fit=setenv bootargs console=${console} \0" \
- "loadfit=run args_fit; bootm ${loadaddr}#${fdtfile};\0" \
+ "loadfit=run args_mmc; bootm ${loadaddr}#${fdtfile};\0" \
/*
* DDR information. If the CONFIG_NR_DRAM_BANKS is not defined,
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] ti_armv7_common: env: Use args_mmc in FIT loading path
2017-03-10 21:53 Andrew F. Davis
@ 2017-03-13 4:05 ` Lokesh Vutla
0 siblings, 0 replies; 3+ messages in thread
From: Lokesh Vutla @ 2017-03-13 4:05 UTC (permalink / raw)
To: u-boot
On Saturday 11 March 2017 03:23 AM, Andrew F. Davis wrote:
> The env command 'args_fit' does not define a root path, this forces us to
> embed the rootfs into the FIT image. FIT images do not need to contain a
> rootfs, when they do not the kernel will fall-back to the kernel argument
> 'root', if this is not defined the kernel will not boot. It is safe to
> add this as when we do have the rootfs in FIT this argument is ignored.
> As 'loadfit' is only called from the MMC boot path, use 'args_mmc' to
> correctly populate 'bootargs'.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] ti_armv7_common: env: Use args_mmc in FIT loading path
@ 2017-04-07 14:52 Andrew F. Davis
0 siblings, 0 replies; 3+ messages in thread
From: Andrew F. Davis @ 2017-04-07 14:52 UTC (permalink / raw)
To: u-boot
The env command 'args_fit' does not define a root path, this forces us to
embed the rootfs into the FIT image. FIT images do not need to contain a
rootfs, when they do not the kernel will fall-back to the kernel argument
'root', if this is not defined the kernel will not boot. It is safe to
add this as when we do have the rootfs in FIT this argument is ignored.
As 'loadfit' is only called from the MMC boot path, use 'args_mmc' to
correctly populate 'bootargs'.
Signed-off-by: Andrew F. Davis <afd@ti.com>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
---
include/configs/ti_armv7_common.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
index a4ec4ce00a..b2950efd47 100644
--- a/include/configs/ti_armv7_common.h
+++ b/include/configs/ti_armv7_common.h
@@ -117,8 +117,7 @@
"fit_loadaddr=0x88000000\0" \
"fit_bootfile=fitImage.itb\0" \
"update_to_fit=setenv loadaddr ${fit_loadaddr}; setenv bootfile ${fit_bootfile}\0" \
- "args_fit=setenv bootargs console=${console} \0" \
- "loadfit=run args_fit; bootm ${loadaddr}#${fdtfile};\0" \
+ "loadfit=run args_mmc; bootm ${loadaddr}#${fdtfile};\0" \
/*
* DDR information. If the CONFIG_NR_DRAM_BANKS is not defined,
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-07 14:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-07 14:52 [U-Boot] [PATCH] ti_armv7_common: env: Use args_mmc in FIT loading path Andrew F. Davis
-- strict thread matches above, loose matches on Subject: below --
2017-03-10 21:53 Andrew F. Davis
2017-03-13 4:05 ` Lokesh Vutla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox