[U-Boot] [PULL] Please pull u-boot-imx

Stefano Babic
2018-01-16T09:40:48Z

Hi Tom,

On 16/01/2018 01:00, Tom Rini wrote:
> On Mon, Jan 15, 2018 at 06:52:01PM +0100, Stefano Babic wrote:
>
>> Hi Tom,
>>
>> please pull from u-boot-imx, thanks !
>>
>> The following changes since commit 373b9003410b44a1133060c2e63483b278fb476b:
>>
>> Merge git://git.denx.de/u-boot-sunxi (2018-01-11 14:14:19 -0500)
>>
>> are available in the git repository at:
>>
>> git://www.denx.de/git/u-boot-imx.git master
>>
>> for you to fetch changes up to 9587b0d61133c025d48ebf480aa021fc2fdd53a7:
>>
>> arm: imx: hab: Add hab_failsafe console command (2018-01-14 17:26:30
>> +0100)
>>
>
> Applied to u-boot/master, thanks!
>
> But please note that checkpatch has a lot to say, some of which should
> probably be addressed:
>

Ouch.....

I will check it :-)

Regards,
Stefano

> WARNING: please write a paragraph that describes the config symbol fully
> #51: FILE: arch/arm/mach-imx/mx6/Kconfig:380:
> +config TARGET_SKSIMX6
>
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #67:
> new file mode 100644
>
> WARNING: line over 80 characters
> #171: FILE: board/sks-kinkel/sksimx6/sksimx6.c:62:
> + IOMUX_PADS(PAD_NANDF_D0__GPIO2_IO00 | MUX_PAD_CTRL(NO_PAD_CTRL)),/* CD */
>
> CHECK: Blank lines aren't necessary after an open brace '{'
> #215: FILE: board/sks-kinkel/sksimx6/sksimx6.c:106:
> +{
> +
>
> CHECK: Blank lines aren't necessary before a close brace '}'
> #245: FILE: board/sks-kinkel/sksimx6/sksimx6.c:136:
> +
> +}
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #249: FILE: board/sks-kinkel/sksimx6/sksimx6.c:140:
> + uint32_t base = IMX_FEC_BASE;
>
> CHECK: Alignment should match open parenthesis
> #261: FILE: board/sks-kinkel/sksimx6/sksimx6.c:152:
> + phydev = phy_find_by_mask(bus, (0xf << CONFIG_FEC_MXC_PHYADDR),
> + PHY_INTERFACE_MODE_RGMII);
>
> WARNING: unnecessary whitespace before a quoted newline
> #333: FILE: board/sks-kinkel/sksimx6/sksimx6.c:224:
> + printf("Warning: failed to initialize mmc dev \n");
>
> CHECK: Please don't use multiple blank lines
> #350: FILE: board/sks-kinkel/sksimx6/sksimx6.c:241:
> +
> +
>
> WARNING: line over 80 characters
> #471: FILE: board/sks-kinkel/sksimx6/sksimx6.c:362:
> + mx6_dram_cfg(&mem_qdl, &mx6dl_1g_mmdc_calib, &mt41k128m16jt_125);
>
> CHECK: Please don't use multiple blank lines
> #601: FILE: include/configs/sksimx6.h:7:
> +
> +
>
> WARNING: please, no space before tabs
> #670: FILE: include/configs/sksimx6.h:76:
> +^I"addmisc=setenv bootargs ${bootargs} ${miscargs}\0" ^I^I\$
>
> WARNING: please, no space before tabs
> #675: FILE: include/configs/sksimx6.h:81:
> +^I"fdt_addr_r=0x18000000\0" ^I^I^I^I^I\$
>
> WARNING: please, no space before tabs
> #677: FILE: include/configs/sksimx6.h:83:
> +^I"fdt_high=0xffffffff\0" ^I^I^I^I^I\$
>
> WARNING: please, no space before tabs
> #678: FILE: include/configs/sksimx6.h:84:
> +^I"kernel_addr_r=" __stringify(CONFIG_LOADADDR) "\0" ^I^I\$
>
> WARNING: please, no space before tabs
> #681: FILE: include/configs/sksimx6.h:87:
> +^I"mmcboot=if run mmcload;then " ^I^I^I^I^I\$
>
> WARNING: please, no space before tabs
> #683: FILE: include/configs/sksimx6.h:89:
> +^I^I^I"bootm;fi\0" ^I^I^I^I^I\$
>
> total: 0 errors, 11 warnings, 6 checks, 611 lines checked
> WARNING: line over 80 characters
> #38: FILE: drivers/misc/mxc_ocotp.c:356:
> + printf("mxc_ocotp: The word has been programmed, no more write\n");
>
> total: 0 errors, 1 warnings, 0 checks, 23 lines checked
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #34:
> new file mode 100644
>
> WARNING: line over 80 characters
> #549: FILE: arch/arm/dts/imx6sx-sdb.dtsi:367:
> + MX6SX_PAD_ENET2_RX_CLK__ENET2_REF_CLK_25M 0x91
>
> WARNING: line over 80 characters
> #555: FILE: arch/arm/dts/imx6sx-sdb.dtsi:373:
> + MX6SX_PAD_ENET2_COL__GPIO2_IO_6 0x80000000
>
> WARNING: line over 80 characters
> #585: FILE: arch/arm/dts/imx6sx-sdb.dtsi:403:
> + MX6SX_PAD_GPIO1_IO01__I2C1_SDA 0x4001b8b1
>
> WARNING: line over 80 characters
> #586: FILE: arch/arm/dts/imx6sx-sdb.dtsi:404:
> + MX6SX_PAD_GPIO1_IO00__I2C1_SCL 0x4001b8b1
>
> WARNING: line over 80 characters
> #592: FILE: arch/arm/dts/imx6sx-sdb.dtsi:410:
> + MX6SX_PAD_KEY_ROW4__I2C3_SDA 0x4001b8b1
>
> WARNING: line over 80 characters
> #593: FILE: arch/arm/dts/imx6sx-sdb.dtsi:411:
> + MX6SX_PAD_KEY_COL4__I2C3_SCL 0x4001b8b1
>
> WARNING: line over 80 characters
> #599: FILE: arch/arm/dts/imx6sx-sdb.dtsi:417:
> + MX6SX_PAD_CSI_DATA07__I2C4_SDA 0x4001b8b1
>
> WARNING: line over 80 characters
> #600: FILE: arch/arm/dts/imx6sx-sdb.dtsi:418:
> + MX6SX_PAD_CSI_DATA06__I2C4_SCL 0x4001b8b1
>
> WARNING: line over 80 characters
> #640: FILE: arch/arm/dts/imx6sx-sdb.dtsi:458:
> + MX6SX_PAD_QSPI1A_DATA0__GPIO4_IO_16 0x80000000
>
> WARNING: line over 80 characters
> #740: FILE: arch/arm/dts/imx6sx-sdb.dtsi:558:
> + MX6SX_PAD_KEY_COL0__GPIO2_IO_10 0x17059 /* CD */
>
> WARNING: line over 80 characters
> #741: FILE: arch/arm/dts/imx6sx-sdb.dtsi:559:
> + MX6SX_PAD_KEY_ROW0__GPIO2_IO_15 0x17059 /* WP */
>
> WARNING: line over 80 characters
> #783: FILE: arch/arm/dts/imx6sx-sdb.dtsi:601:
> + MX6SX_PAD_SD4_DATA7__GPIO6_IO_21 0x17059 /* CD */
>
> WARNING: line over 80 characters
> #784: FILE: arch/arm/dts/imx6sx-sdb.dtsi:602:
> + MX6SX_PAD_SD4_DATA6__GPIO6_IO_20 0x17059 /* WP */
>
> total: 0 errors, 14 warnings, 0 checks, 757 lines checked
> WARNING: 'framwork' may be misspelled - perhaps 'framework'?
> #7:
> framwork now and wdog reset will be triggered once set WDOG_B mux
>
> WARNING: 'framwork' may be misspelled - perhaps 'framework'?
> #49: FILE: board/freescale/mx6sxsabresd/mx6sxsabresd.c:306:
> + * framwork now and wdog reset will be triggered once set WDOG_B mux
>
> total: 0 errors, 2 warnings, 0 checks, 33 lines checked
> WARNING: line over 80 characters
> #95: FILE: arch/arm/mach-imx/mx5/clock.c:918:
> +static int do_mx5_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>
> total: 0 errors, 1 warnings, 0 checks, 85 lines checked
> CHECK: Alignment should match open parenthesis
> #60: FILE: board/toradex/apalis_imx6/pf0100.c:214:
> +static int do_pf0100_prog(cmd_tbl_t *cmdtp, int flag, int argc,
> char * const argv[])
>
> CHECK: Alignment should match open parenthesis
> #109: FILE: board/toradex/colibri_imx6/pf0100.c:196:
> +static int do_pf0100_prog(cmd_tbl_t *cmdtp, int flag, int argc,
> char * const argv[])
>
> total: 0 errors, 0 warnings, 2 checks, 79 lines checked
> WARNING: line over 80 characters
> #56: FILE: include/configs/cm_fx6.h:158:
> + "if test $board_name = Utilite && test $board_rev = MX6Q ; then " \
>
> total: 0 errors, 1 warnings, 0 checks, 26 lines checked
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #45: FILE: arch/arm/include/asm/mach-imx/hab.h:148:
> +int authenticate_image(uint32_t ddr_start, uint32_t image_size);
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #57: FILE: arch/arm/mach-imx/hab.c:413:
> +int authenticate_image(uint32_t ddr_start, uint32_t image_size)
>
> total: 0 errors, 0 warnings, 2 checks, 15 lines checked
> WARNING: Prefer using '"%s...", __func__' to using 'authenticate_image', this function's name, in a string
> #95: FILE: arch/arm/mach-imx/hab.c:465:
> + puts("\nCalling authenticate_image in ROM\n");
>
> total: 0 errors, 1 warnings, 0 checks, 160 lines checked
> WARNING: Prefer using '"%s...", __func__' to using 'authenticate_image', this function's name, in a string
> #85: FILE: arch/arm/mach-imx/hab.c:469:
> + puts("\nCalling authenticate_image in ROM\n");
>
> total: 0 errors, 1 warnings, 0 checks, 135 lines checked
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #67: FILE: arch/arm/include/asm/mach-imx/hab.h:151:
> +int authenticate_image(uint32_t ddr_start, uint32_t image_size,
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #159: FILE: arch/arm/mach-imx/hab.c:386:
> +int authenticate_image(uint32_t ddr_start, uint32_t image_size,
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #165: FILE: arch/arm/mach-imx/hab.c:391:
> + uint32_t ivt_addr = 0;
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #252: FILE: arch/arm/mach-imx/spl.c:192:
> + uint32_t offset;
>
> total: 0 errors, 0 warnings, 4 checks, 188 lines checked
> CHECK: Prefer kernel type 'u8' over 'uint8_t'
> #49: FILE: arch/arm/include/asm/mach-imx/hab.h:25:
> + uint8_t magic;
>
> CHECK: Prefer kernel type 'u16' over 'uint16_t'
> #50: FILE: arch/arm/include/asm/mach-imx/hab.h:26:
> + uint16_t length;
>
> CHECK: Prefer kernel type 'u8' over 'uint8_t'
> #51: FILE: arch/arm/include/asm/mach-imx/hab.h:27:
> + uint8_t version;
>
> WARNING: __packed is preferred over __attribute__((packed))
> #52: FILE: arch/arm/include/asm/mach-imx/hab.h:28:
> +} __attribute__((packed));
>
> WARNING: Adding new packed members is to be done with care
> #52: FILE: arch/arm/include/asm/mach-imx/hab.h:28:
> +} __attribute__((packed));
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #56: FILE: arch/arm/include/asm/mach-imx/hab.h:32:
> + uint32_t entry; /* Absolute address of first instruction */
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #57: FILE: arch/arm/include/asm/mach-imx/hab.h:33:
> + uint32_t reserved1; /* Reserved should be zero */
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #58: FILE: arch/arm/include/asm/mach-imx/hab.h:34:
> + uint32_t dcd; /* Absolute address of the image DCD */
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #59: FILE: arch/arm/include/asm/mach-imx/hab.h:35:
> + uint32_t boot; /* Absolute address of the boot data */
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #60: FILE: arch/arm/include/asm/mach-imx/hab.h:36:
> + uint32_t self; /* Absolute address of the IVT */
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #61: FILE: arch/arm/include/asm/mach-imx/hab.h:37:
> + uint32_t csf; /* Absolute address of the CSF */
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #62: FILE: arch/arm/include/asm/mach-imx/hab.h:38:
> + uint32_t reserved2; /* Reserved should be zero */
>
> total: 0 errors, 2 warnings, 10 checks, 34 lines checked
> CHECK: Prefer kernel type 'u8' over 'uint8_t'
> #172: FILE: arch/arm/mach-imx/hab.c:212:
> +static uint8_t hab_statuses[5] = {
>
> CHECK: Prefer kernel type 'u8' over 'uint8_t'
> #181: FILE: arch/arm/mach-imx/hab.c:220:
> +static uint8_t hab_reasons[26] = {
>
> CHECK: Prefer kernel type 'u8' over 'uint8_t'
> #190: FILE: arch/arm/mach-imx/hab.c:249:
> +static uint8_t hab_contexts[12] = {
>
> CHECK: Prefer kernel type 'u8' over 'uint8_t'
> #199: FILE: arch/arm/mach-imx/hab.c:264:
> +static uint8_t hab_engines[16] = {
>
> CHECK: Prefer kernel type 'u8' over 'uint8_t'
> #208: FILE: arch/arm/mach-imx/hab.c:295:
> +static void process_event_record(uint8_t *event_data, size_t bytes)
>
> CHECK: Prefer kernel type 'u8' over 'uint8_t'
> #217: FILE: arch/arm/mach-imx/hab.c:305:
> +static void display_event(uint8_t *event_data, size_t bytes)
>
> total: 0 errors, 0 warnings, 6 checks, 213 lines checked
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #38: FILE: arch/arm/include/asm/mach-imx/hab.h:188:
> +int imx_hab_authenticate_image(uint32_t ddr_start, uint32_t image_size,
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> #61: FILE: arch/arm/mach-imx/hab.c:438:
> +int imx_hab_authenticate_image(uint32_t ddr_start, uint32_t image_size,
>
> total: 0 errors, 0 warnings, 2 checks, 38 lines checked
>

--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================