From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Tue, 18 Apr 2017 16:44:33 +0200 Subject: [U-Boot] [PATCH] spl: dfu: compilation fixes for spl-dfu In-Reply-To: <1492525535-28091-1-git-send-email-ravibabu@ti.com> References: <1492525535-28091-1-git-send-email-ravibabu@ti.com> Message-ID: <20170418164433.4644c46c@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Ravi, > This patch fixes the compilation error > common/cli_hush.c:3349: undefined reference to 'realloc_simple' > > The dfu uses run_command(), it is part of cli_hush.c > but defining CONFIG_HUSH_PARSER for spl-dfu causes > this compilation error. > > Signed-off-by: Ravi Babu > --- > common/cli.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/cli.c b/common/cli.c > index a433ef2..5e0869b 100644 > --- a/common/cli.c > +++ b/common/cli.c > @@ -28,7 +28,7 @@ DECLARE_GLOBAL_DATA_PTR; > */ > int run_command(const char *cmd, int flag) > { > -#ifndef CONFIG_HUSH_PARSER > +#if defined(CONFIG_SPL_DFU_SUPPORT) || !defined(CONFIG_HUSH_PARSER) I must admit that this seems odd to me....since we should avoided adding (SPL DFU) dependency to common parser code. Maybe some kconfig tweaks would help? > /* > * cli_run_command can return 0 or 1 for success, so clean up > * its result. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de