From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] ddr: fsl: incorrect logical constraint in populate_memctl_options
Date: Wed, 19 Apr 2017 09:04:08 -0400 [thread overview]
Message-ID: <20170419130408.GD19487@bill-the-cat> (raw)
In-Reply-To: <20170415132349.25841-1-xypron.glpk@gmx.de>
On Sat, Apr 15, 2017 at 03:23:49PM +0200, xypron.glpk at gmx.de wrote:
> (pdimm[0].data_width >= 32) || (pdimm[0].data_width <= 40)
> is always true.
>
> We should use && here.
>
> The problem was indicated by cppcheck.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: York Sun <york.sun@nxp.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170419/729cd3a2/attachment.sig>
prev parent reply other threads:[~2017-04-19 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 13:23 [U-Boot] [PATCH] ddr: fsl: incorrect logical constraint in populate_memctl_options Heinrich Schuchardt
2017-04-15 16:12 ` Tom Rini
2017-04-15 16:43 ` York Sun
2017-04-19 13:04 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419130408.GD19487@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox