From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 19 Apr 2017 09:04:08 -0400 Subject: [U-Boot] ddr: fsl: incorrect logical constraint in populate_memctl_options In-Reply-To: <20170415132349.25841-1-xypron.glpk@gmx.de> References: <20170415132349.25841-1-xypron.glpk@gmx.de> Message-ID: <20170419130408.GD19487@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Apr 15, 2017 at 03:23:49PM +0200, xypron.glpk at gmx.de wrote: > (pdimm[0].data_width >= 32) || (pdimm[0].data_width <= 40) > is always true. > > We should use && here. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Tom Rini > Reviewed-by: York Sun Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: