[U-Boot] [ANN] U-Boot v2017.05-rc2 released

Marek Vasut
2017-04-19T09:51:53Z

On 04/19/2017 11:46 AM, Heiko Schocher wrote:
> Hello Marek,
>
> Am 19.04.2017 um 10:43 schrieb Marek Vasut:
>> On 04/19/2017 07:29 AM, Heiko Schocher wrote:
>>> Hello Tom,
>>>
>>> added Lukasz, Marek and Felipe,
>>>
>>> Am 18.04.2017 um 00:22 schrieb Tom Rini:
>>>> Hey all,
>>>>
>>>> It's release day and v2017.05-rc2 is out. I think my patchwork
>>>> queue is
>>>> looking good currently. I have some outstanding removal patches to
>>>> take
>>>> from Masahiro related to architectures that I removed as promised. The
>>>> release is bigger than I really wanted, but since I was on vacation for
>>>> most of the normal -rc1 window, stuff came in that would have come in
>>>> then now, instead. Things are on track for -rc3 on the 1st.
>>>
>>> My weekly dfu test on the siemens smartweb board failed with
>>> current HEAD.
>>>
>>> I started an automated git bisect with tbot, and found:
>>>
>>> 2017-04-19 07:24:30,717:CON :tbotlib # tb_ctrl: git bisect
>>> visualize
>>> 2017-04-19 07:24:30,783:CON :tbotlib # tb_ctrl: commit
>>> 842778a091047b0c868efa12229633959f711152
>>> Author: Felipe Balbi <felipe.balbi@linux.intel.com>
>>> Date: Wed Feb 22 17:12:40 2017 +0200
>>> usb: gadget: g_dnl: only set iSerialNumber if we have a serial#
>>>
>>> We don't want to claim that we support a serial number string and
>>> later return nothing. Because of that, if g_dnl_serial is an empty
>>> string, let's skip setting iSerialNumber to a valid number.
>>>
>>> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>> hs at pollux [ 7:24:30] ttbott>
>>> 2017-04-19 07:24:31,769:CON :tbotlib # tb_ctrl: git bisect log
>>> 2017-04-19 07:24:31,836:CON :tbotlib # tb_ctrl: git bisect start
> [...]
>>>
>>> Any ideas?
>>
>> Is your board setting up the serial number with g_dnl_set_serialnumber()
>> correctly ?
>
> Hmm.. good question ... its done here:
>
> http://git.denx.de/?p=u-boot.git;a=blob;f=board/siemens/common/factoryset.c;h=6c869ed2b035a0e9f840e1f6f960fe0e6ac824e5;hb=f6c1df44b815a08585e7fd3805a1db51a5955d09#l313
>
>
> but may this does not work correct and now pops up.
>
> I try to find out more, thanks for the hint!

Just check if you're not passing in NULL or empty string, that might be
it. Otherwise the USB code is botched.

--
Best regards,
Marek Vasut