* [U-Boot] [PATCH] arm: dts: imx: add aliases for usbotg nodes
@ 2017-04-24 21:20 Alexey Ignatov
2017-04-26 19:12 ` [U-Boot] " Tom Rini
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Alexey Ignatov @ 2017-04-24 21:20 UTC (permalink / raw)
To: u-boot
Aliases must be present for USB gadget with DM_USB. Without this,
usb_setup_ehci_gadget() fails because it can't find required devices
in UCLASS_USB.
Signed-off-by: Alexey Ignatov <lexszero@gmail.com>
---
arch/arm/dts/imx6qdl.dtsi | 1 +
arch/arm/dts/imx6sll.dtsi | 2 ++
arch/arm/dts/imx6sx.dtsi | 2 ++
arch/arm/dts/imx6ul.dtsi | 2 ++
arch/arm/dts/imx6ull.dtsi | 2 ++
5 files changed, 9 insertions(+)
diff --git a/arch/arm/dts/imx6qdl.dtsi b/arch/arm/dts/imx6qdl.dtsi
index b13b0b2db8..1253d14b18 100644
--- a/arch/arm/dts/imx6qdl.dtsi
+++ b/arch/arm/dts/imx6qdl.dtsi
@@ -46,6 +46,7 @@
spi3 = &ecspi4;
usbphy0 = &usbphy1;
usbphy1 = &usbphy2;
+ usb0 = &usbotg1;
};
clocks {
diff --git a/arch/arm/dts/imx6sll.dtsi b/arch/arm/dts/imx6sll.dtsi
index 349c47a03a..95c04edfb7 100644
--- a/arch/arm/dts/imx6sll.dtsi
+++ b/arch/arm/dts/imx6sll.dtsi
@@ -37,6 +37,8 @@
spi4 = &ecspi4;
usbphy0 = &usbphy1;
usbphy1 = &usbphy2;
+ usb0 = &usbotg1;
+ usb1 = &usbotg2;
};
cpus {
diff --git a/arch/arm/dts/imx6sx.dtsi b/arch/arm/dts/imx6sx.dtsi
index 1a473e83ef..99e8f0a4df 100644
--- a/arch/arm/dts/imx6sx.dtsi
+++ b/arch/arm/dts/imx6sx.dtsi
@@ -47,6 +47,8 @@
spi4 = &ecspi5;
usbphy0 = &usbphy1;
usbphy1 = &usbphy2;
+ usb0 = &usbotg1;
+ usb1 = &usbotg2;
};
cpus {
diff --git a/arch/arm/dts/imx6ul.dtsi b/arch/arm/dts/imx6ul.dtsi
index c5c05fdccc..0b27ba85a0 100644
--- a/arch/arm/dts/imx6ul.dtsi
+++ b/arch/arm/dts/imx6ul.dtsi
@@ -45,6 +45,8 @@
spi3 = &ecspi4;
usbphy0 = &usbphy1;
usbphy1 = &usbphy2;
+ usb0 = &usbotg1;
+ usb1 = &usbotg2;
};
cpus {
diff --git a/arch/arm/dts/imx6ull.dtsi b/arch/arm/dts/imx6ull.dtsi
index 65950e8019..61ce305428 100644
--- a/arch/arm/dts/imx6ull.dtsi
+++ b/arch/arm/dts/imx6ull.dtsi
@@ -44,6 +44,8 @@
spi3 = &ecspi4;
usbphy0 = &usbphy1;
usbphy1 = &usbphy2;
+ usb0 = &usbotg1;
+ usb1 = &usbotg2;
};
cpus {
--
2.12.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [U-Boot] arm: dts: imx: add aliases for usbotg nodes
2017-04-24 21:20 [U-Boot] [PATCH] arm: dts: imx: add aliases for usbotg nodes Alexey Ignatov
@ 2017-04-26 19:12 ` Tom Rini
2017-04-27 7:53 ` [U-Boot] [PATCH] " Sébastien Szymanski
2017-05-18 8:53 ` Stefano Babic
2 siblings, 0 replies; 7+ messages in thread
From: Tom Rini @ 2017-04-26 19:12 UTC (permalink / raw)
To: u-boot
On Tue, Apr 25, 2017 at 12:20:52AM +0300, Alexey Ignatov wrote:
> Aliases must be present for USB gadget with DM_USB. Without this,
> usb_setup_ehci_gadget() fails because it can't find required devices
> in UCLASS_USB.
>
> Signed-off-by: Alexey Ignatov <lexszero@gmail.com>
> ---
> arch/arm/dts/imx6qdl.dtsi | 1 +
> arch/arm/dts/imx6sll.dtsi | 2 ++
> arch/arm/dts/imx6sx.dtsi | 2 ++
> arch/arm/dts/imx6ul.dtsi | 2 ++
> arch/arm/dts/imx6ull.dtsi | 2 ++
> 5 files changed, 9 insertions(+)
>
> diff --git a/arch/arm/dts/imx6qdl.dtsi b/arch/arm/dts/imx6qdl.dtsi
> index b13b0b2db8..1253d14b18 100644
> --- a/arch/arm/dts/imx6qdl.dtsi
> +++ b/arch/arm/dts/imx6qdl.dtsi
> @@ -46,6 +46,7 @@
> spi3 = &ecspi4;
> usbphy0 = &usbphy1;
> usbphy1 = &usbphy2;
> + usb0 = &usbotg1;
> };
>
> clocks {
> diff --git a/arch/arm/dts/imx6sll.dtsi b/arch/arm/dts/imx6sll.dtsi
> index 349c47a03a..95c04edfb7 100644
> --- a/arch/arm/dts/imx6sll.dtsi
> +++ b/arch/arm/dts/imx6sll.dtsi
> @@ -37,6 +37,8 @@
> spi4 = &ecspi4;
> usbphy0 = &usbphy1;
> usbphy1 = &usbphy2;
> + usb0 = &usbotg1;
> + usb1 = &usbotg2;
> };
>
> cpus {
> diff --git a/arch/arm/dts/imx6sx.dtsi b/arch/arm/dts/imx6sx.dtsi
> index 1a473e83ef..99e8f0a4df 100644
> --- a/arch/arm/dts/imx6sx.dtsi
> +++ b/arch/arm/dts/imx6sx.dtsi
> @@ -47,6 +47,8 @@
> spi4 = &ecspi5;
> usbphy0 = &usbphy1;
> usbphy1 = &usbphy2;
> + usb0 = &usbotg1;
> + usb1 = &usbotg2;
> };
>
> cpus {
> diff --git a/arch/arm/dts/imx6ul.dtsi b/arch/arm/dts/imx6ul.dtsi
> index c5c05fdccc..0b27ba85a0 100644
> --- a/arch/arm/dts/imx6ul.dtsi
> +++ b/arch/arm/dts/imx6ul.dtsi
> @@ -45,6 +45,8 @@
> spi3 = &ecspi4;
> usbphy0 = &usbphy1;
> usbphy1 = &usbphy2;
> + usb0 = &usbotg1;
> + usb1 = &usbotg2;
> };
>
> cpus {
> diff --git a/arch/arm/dts/imx6ull.dtsi b/arch/arm/dts/imx6ull.dtsi
> index 65950e8019..61ce305428 100644
> --- a/arch/arm/dts/imx6ull.dtsi
> +++ b/arch/arm/dts/imx6ull.dtsi
> @@ -44,6 +44,8 @@
> spi3 = &ecspi4;
> usbphy0 = &usbphy1;
> usbphy1 = &usbphy2;
> + usb0 = &usbotg1;
> + usb1 = &usbotg2;
> };
>
> cpus {
Do these come from the Linux dtsi file or are being pushed there? If
not, you need to put it in the -u-boot.dtsi file (but really see about
pushing it upstream). Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170426/d84847c3/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] arm: dts: imx: add aliases for usbotg nodes
2017-04-24 21:20 [U-Boot] [PATCH] arm: dts: imx: add aliases for usbotg nodes Alexey Ignatov
2017-04-26 19:12 ` [U-Boot] " Tom Rini
@ 2017-04-27 7:53 ` Sébastien Szymanski
2017-05-18 8:53 ` Stefano Babic
2 siblings, 0 replies; 7+ messages in thread
From: Sébastien Szymanski @ 2017-04-27 7:53 UTC (permalink / raw)
To: u-boot
Hi,
On 04/24/2017 11:20 PM, Alexey Ignatov wrote:
> Aliases must be present for USB gadget with DM_USB. Without this,
> usb_setup_ehci_gadget() fails because it can't find required devices
> in UCLASS_USB.
>
> Signed-off-by: Alexey Ignatov <lexszero@gmail.com>
> ---
> arch/arm/dts/imx6qdl.dtsi | 1 +
> arch/arm/dts/imx6sll.dtsi | 2 ++
> arch/arm/dts/imx6sx.dtsi | 2 ++
> arch/arm/dts/imx6ul.dtsi | 2 ++
...
>
> cpus {
> diff --git a/arch/arm/dts/imx6ul.dtsi b/arch/arm/dts/imx6ul.dtsi
> index c5c05fdccc..0b27ba85a0 100644
> --- a/arch/arm/dts/imx6ul.dtsi
> +++ b/arch/arm/dts/imx6ul.dtsi
> @@ -45,6 +45,8 @@
> spi3 = &ecspi4;
> usbphy0 = &usbphy1;
> usbphy1 = &usbphy2;
> + usb0 = &usbotg1;
> + usb1 = &usbotg2;
> };
>
> cpus {
The imx6ul.dtsi file already has usbotg{0,1} aliases.
http://git.denx.de/?p=u-boot.git;a=commit;h=b3cab814232d3b5e165c09ffad4af5b71bde15f3
Regards,
--
Sébastien Szymanski
Software Engineer, Armadeus Systems
sebastien.szymanski at armadeus.com
Tel: +33 (0)9 72 29 41 44
Fax: +33 (0)9 72 28 79 26
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] arm: dts: imx: add aliases for usbotg nodes
2017-04-24 21:20 [U-Boot] [PATCH] arm: dts: imx: add aliases for usbotg nodes Alexey Ignatov
2017-04-26 19:12 ` [U-Boot] " Tom Rini
2017-04-27 7:53 ` [U-Boot] [PATCH] " Sébastien Szymanski
@ 2017-05-18 8:53 ` Stefano Babic
2017-05-18 10:13 ` Stefano Babic
2 siblings, 1 reply; 7+ messages in thread
From: Stefano Babic @ 2017-05-18 8:53 UTC (permalink / raw)
To: u-boot
On 24/04/2017 23:20, Alexey Ignatov wrote:
> Aliases must be present for USB gadget with DM_USB. Without this,
> usb_setup_ehci_gadget() fails because it can't find required devices
> in UCLASS_USB.
>
> Signed-off-by: Alexey Ignatov <lexszero@gmail.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: dts: imx: add aliases for usbotg nodes
2017-05-18 8:53 ` Stefano Babic
@ 2017-05-18 10:13 ` Stefano Babic
2017-05-18 10:28 ` Sébastien Szymanski
0 siblings, 1 reply; 7+ messages in thread
From: Stefano Babic @ 2017-05-18 10:13 UTC (permalink / raw)
To: u-boot
On 18/05/2017 10:53, Stefano Babic wrote:
> On 24/04/2017 23:20, Alexey Ignatov wrote:
>> Aliases must be present for USB gadget with DM_USB. Without this,
>> usb_setup_ehci_gadget() fails because it can't find required devices
>> in UCLASS_USB.
>>
>> Signed-off-by: Alexey Ignatov <lexszero@gmail.com>
>> ---
>
>
> Applied to u-boot-imx, thanks !
>
Sorry, I cannot. This patch is breaking several boards with "Reference
to non-existent node or label "usbotg1"" when DTS is compiled:
opos6uldev
mx6sllevk_plugin
mx6slevk_spinor
imx6qdl_icore_rqs_mmc
...
Can you check this, please ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: dts: imx: add aliases for usbotg nodes
2017-05-18 10:13 ` Stefano Babic
@ 2017-05-18 10:28 ` Sébastien Szymanski
2017-05-18 10:26 ` Stefano Babic
0 siblings, 1 reply; 7+ messages in thread
From: Sébastien Szymanski @ 2017-05-18 10:28 UTC (permalink / raw)
To: u-boot
Hi,
On 05/18/2017 12:13 PM, Stefano Babic wrote:
> On 18/05/2017 10:53, Stefano Babic wrote:
>> On 24/04/2017 23:20, Alexey Ignatov wrote:
>>> Aliases must be present for USB gadget with DM_USB. Without this,
>>> usb_setup_ehci_gadget() fails because it can't find required devices
>>> in UCLASS_USB.
>>>
>>> Signed-off-by: Alexey Ignatov <lexszero@gmail.com>
>>> ---
>>
>>
>> Applied to u-boot-imx, thanks !
>>
>
> Sorry, I cannot. This patch is breaking several boards with "Reference
> to non-existent node or label "usbotg1"" when DTS is compiled:
>
> opos6uldev
> mx6sllevk_plugin
> mx6slevk_spinor
> imx6qdl_icore_rqs_mmc
> ...
>
It looks like my comment has been missed.
The imx6ul.dtsi file already has usbotg{0,1} aliases.
Regards,
>
> Can you check this, please ?
>
> Best regards,
> Stefano Babic
>
>
--
Sébastien Szymanski
Software Engineer, Armadeus Systems
sebastien.szymanski at armadeus.com
Tel: +33 (0)9 72 29 41 44
Fax: +33 (0)9 72 28 79 26
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] arm: dts: imx: add aliases for usbotg nodes
2017-05-18 10:28 ` Sébastien Szymanski
@ 2017-05-18 10:26 ` Stefano Babic
0 siblings, 0 replies; 7+ messages in thread
From: Stefano Babic @ 2017-05-18 10:26 UTC (permalink / raw)
To: u-boot
On 18/05/2017 12:28, Sébastien Szymanski wrote:
> Hi,
>
> On 05/18/2017 12:13 PM, Stefano Babic wrote:
>> On 18/05/2017 10:53, Stefano Babic wrote:
>>> On 24/04/2017 23:20, Alexey Ignatov wrote:
>>>> Aliases must be present for USB gadget with DM_USB. Without this,
>>>> usb_setup_ehci_gadget() fails because it can't find required devices
>>>> in UCLASS_USB.
>>>>
>>>> Signed-off-by: Alexey Ignatov <lexszero@gmail.com>
>>>> ---
>>>
>>>
>>> Applied to u-boot-imx, thanks !
>>>
>>
>> Sorry, I cannot. This patch is breaking several boards with "Reference
>> to non-existent node or label "usbotg1"" when DTS is compiled:
>>
>> opos6uldev
>> mx6sllevk_plugin
>> mx6slevk_spinor
>> imx6qdl_icore_rqs_mmc
>> ...
>>
>
> It looks like my comment has been missed.
> The imx6ul.dtsi file already has usbotg{0,1} aliases.
Yes, sorry, I have missed them. Thanks for pointing me in the right
direction.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-05-18 10:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-24 21:20 [U-Boot] [PATCH] arm: dts: imx: add aliases for usbotg nodes Alexey Ignatov
2017-04-26 19:12 ` [U-Boot] " Tom Rini
2017-04-27 7:53 ` [U-Boot] [PATCH] " Sébastien Szymanski
2017-05-18 8:53 ` Stefano Babic
2017-05-18 10:13 ` Stefano Babic
2017-05-18 10:28 ` Sébastien Szymanski
2017-05-18 10:26 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox