From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Thu, 27 Apr 2017 12:33:08 +0200 Subject: [U-Boot] [PATCH 2/3] common: dfu: ignore reset for spl-dfu In-Reply-To: <6C6B28D4DC342643927BEAFCE8707BF6C0B6E128@DBDE04.ent.ti.com> References: <1493212325-31879-1-git-send-email-ravibabu@ti.com> <1493212325-31879-3-git-send-email-ravibabu@ti.com> <20170427095527.2a3992fe@jawa> <6C6B28D4DC342643927BEAFCE8707BF6C0B6E128@DBDE04.ent.ti.com> Message-ID: <20170427123308.03581555@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 27 Apr 2017 08:26:57 +0000 "B, Ravi" wrote: > Lukasz > > >> diff --git a/common/dfu.c b/common/dfu.c index 0e9f5f5..fa77526 > >> 100644 --- a/common/dfu.c > >> +++ b/common/dfu.c > >> @@ -87,6 +87,9 @@ exit: > >> g_dnl_unregister(); > >> board_usb_cleanup(usbctrl_index, USB_INIT_DEVICE); > >> > >> +#ifdef CONFIG_SPL_BUILD > >> + dfu_reset = 0; > >> +#endif > > >Why do you only ifdef this part? What problem does this solve? > > Common/dfu.c is common code for SPL and U-boot, for SPL-DFU dfu_reset > should not be given. This is must fix. Also this avoid use of > run_command for SPL-DFU altogether, SPL size also will reduce by > removing cli.c/cli_hush.c As I've metioned in the other mail. Kconfig option would be OK. Please look into the dfu_usb_get_reset() __weak function definition. It is by default set to true. You can extend this function to take into account a Kconfig option to return false during SPL builds. > > Regards > Ravi Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de