From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Thu, 27 Apr 2017 15:09:24 +0200 Subject: [U-Boot] [PATCH 2/3] common: dfu: ignore reset for spl-dfu In-Reply-To: <6C6B28D4DC342643927BEAFCE8707BF6C0B6E3EE@DBDE04.ent.ti.com> References: <1493212325-31879-1-git-send-email-ravibabu@ti.com> <1493212325-31879-3-git-send-email-ravibabu@ti.com> <20170427095527.2a3992fe@jawa> <6C6B28D4DC342643927BEAFCE8707BF6C0B6E128@DBDE04.ent.ti.com> <20170427123308.03581555@jawa> <20170427123417.2a9834b0@jawa> <6C6B28D4DC342643927BEAFCE8707BF6C0B6E3EE@DBDE04.ent.ti.com> Message-ID: <20170427150924.0336af9c@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Ravi, > Hi Lukasz > > >> > >> +#ifdef CONFIG_SPL_BUILD > >> > >> + dfu_reset = 0; > >> > >> +#endif > >> > > >> > >Why do you only ifdef this part? What problem does this solve? > >> > > >> > Common/dfu.c is common code for SPL and U-boot, for SPL-DFU > >> > dfu_reset should not be given. This is must fix. Also this avoid > >> > use of run_command for SPL-DFU altogether, SPL size also will > >> > reduce by removing cli.c/cli_hush.c > >> > >> As I've metioned in the other mail. Kconfig option would be OK. > > > And this Kconfig should be _only_ enabled for your SPL-DFU support > > enabled (also in Kconfig). > > I have already added CONFIG_SPL_DFU_NO_RESET option for SPL-DFU in > Kconfig. > > >> > >> Please look into the dfu_usb_get_reset() __weak function > >> definition. > >> > >> It is by default set to true. > >> > >> You can extend this function to take into account a Kconfig option > >> to return false during SPL builds. > >> > > As suggested by you, I feel this is best option. > > I have test verified this option, will post in next patch version. > > __weak bool dfu_usb_get_reset(void) > { > +#ifdef CONFIG_SPL_DFU_NO_RESET > + return false > +#else > return true; > +#endif > } > > Also changing run_command() to do_reset(). > > If (dfu_reset) > do_reset(NULL, 0, 0, NULL); +1 One question - could you write some numbers before SPL dfu tinification and afterwards? I'm just curious how much we can save up. > > Regards > Ravi > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de