From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/11] ARM: at91: ma5d4: Reset CAN controllers late
Date: Tue, 2 May 2017 20:27:42 +0200 [thread overview]
Message-ID: <20170502182750.8907-3-marex@denx.de> (raw)
In-Reply-To: <20170502182750.8907-1-marex@denx.de>
The CAN controllers need slight delay between toggling of their reset
line. Move this action into board_init(), otherwise timer will not be
initialized and the board might hang.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Andreas Bießmann <andreas.devel@googlemail.com>
---
board/aries/ma5d4evk/ma5d4evk.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/board/aries/ma5d4evk/ma5d4evk.c b/board/aries/ma5d4evk/ma5d4evk.c
index dd74e29b8e..aa02b8a34b 100644
--- a/board/aries/ma5d4evk/ma5d4evk.c
+++ b/board/aries/ma5d4evk/ma5d4evk.c
@@ -269,12 +269,6 @@ int board_early_init_f(void)
at91_set_pio_output(AT91_PIO_PORTD, 29, 0);
at91_set_pio_output(AT91_PIO_PORTD, 30, 0);
- /* Reset CAN controllers */
- at91_set_pio_output(AT91_PIO_PORTB, 21, 0);
- udelay(100);
- at91_set_pio_output(AT91_PIO_PORTB, 21, 1);
- at91_pio3_set_pio_pulldown(AT91_PIO_PORTB, 21, 0);
-
ma5d4evk_serial_hw_init();
return 0;
@@ -305,6 +299,12 @@ int board_init(void)
at91_udp_hw_init();
#endif
+ /* Reset CAN controllers */
+ at91_set_pio_output(AT91_PIO_PORTB, 21, 0);
+ udelay(100);
+ at91_set_pio_output(AT91_PIO_PORTB, 21, 1);
+ at91_pio3_set_pio_pulldown(AT91_PIO_PORTB, 21, 0);
+
return 0;
}
--
2.11.0
next prev parent reply other threads:[~2017-05-02 18:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 18:27 [U-Boot] [PATCH 01/11] ARM: atmel: Rename MA5D4EVK Marek Vasut
2017-05-02 18:27 ` [U-Boot] [PATCH 02/11] ARM: at91: ma5d4: Switch DDR2 controller to sequencial address decoding Marek Vasut
2017-06-30 1:26 ` [U-Boot] [U-Boot, " Tom Rini
2017-05-02 18:27 ` Marek Vasut [this message]
2017-06-30 1:26 ` [U-Boot] [U-Boot, 03/11] ARM: at91: ma5d4: Reset CAN controllers late Tom Rini
2017-05-02 18:27 ` [U-Boot] [PATCH 04/11] ARM: at91: ma5d4: Enable DFU and UMS Marek Vasut
2017-06-30 1:26 ` [U-Boot] [U-Boot,04/11] " Tom Rini
2017-05-02 18:27 ` [U-Boot] [PATCH 05/11] ARM: at91: ma5d4: Init SD/MMC controller in SPL Marek Vasut
2017-06-30 1:27 ` [U-Boot] [U-Boot, " Tom Rini
2017-05-02 18:27 ` [U-Boot] [PATCH 06/11] ARM: at91: ma5d4: Swap SD/MMC controller order Marek Vasut
2017-06-30 1:27 ` [U-Boot] [U-Boot, " Tom Rini
2017-05-02 18:27 ` [U-Boot] [PATCH 07/11] ARM: at91: ma5d4: Enable support for booting from eMMC Marek Vasut
2017-06-30 1:27 ` [U-Boot] [U-Boot, " Tom Rini
2017-05-02 18:27 ` [U-Boot] [PATCH 08/11] ARM: at91: ma5d4: Boot from MMC2 when using SAM-BA Marek Vasut
2017-06-30 1:27 ` [U-Boot] [U-Boot, " Tom Rini
2017-05-02 18:27 ` [U-Boot] [PATCH 09/11] ARM: at91: ma5d4: Switch environment start to eMMC Marek Vasut
2017-06-30 1:27 ` [U-Boot] [U-Boot, " Tom Rini
2017-05-02 18:27 ` [U-Boot] [PATCH 10/11] ARM: at91: ma5d4: Enable random ethaddr Marek Vasut
2017-06-30 1:27 ` [U-Boot] [U-Boot, " Tom Rini
2017-05-02 18:27 ` [U-Boot] [PATCH 11/11] ARM: at91: ma5d4: Support both SF and eMMC SoMs Marek Vasut
2017-06-30 1:27 ` [U-Boot] [U-Boot, " Tom Rini
2017-06-30 1:26 ` [U-Boot] [U-Boot,01/11] ARM: atmel: Rename MA5D4EVK Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502182750.8907-3-marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox