From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v4, 3/7] usb: host: xhci-omap: fix double weak board_usb_init functions
Date: Mon, 8 May 2017 15:39:29 -0400 [thread overview]
Message-ID: <20170508193929.GX12511@bill-the-cat> (raw)
In-Reply-To: <1487857181-8938-4-git-send-email-uri.mashiach@compulab.co.il>
On Thu, Feb 23, 2017 at 03:39:37PM +0200, Uri Mashiach wrote:
> A weak version of the function board_usb_init is implemented in:
> common/usb.c
> drivers/usb/host/xhci-omap.c
>
> To fix the double implementations:
> * Convert the board_usb_init function in drivers/usb/host/xhci-omap.c
> normal (not weak).
> * The function board_usb_init in drivers/usb/host/xhci-omap.c calls to
> the weak function omap_xhci_board_usb_init.
> * Rename board version of the function board_usb_init to
> omap_xhci_board_usb_init.
> Done only for boards that defines CONFIG_USB_XHCI_OMAP.
>
> To achieve the same flexibility with the function board_usb_cleanup:
> * Add a normal (not weak) implementation of the function
> board_usb_cleanup in drivers/usb/host/xhci-omap.c
> * The function board_usb_cleanup in drivers/usb/host/xhci-omap.c calls
> to the weak function omap_xhci_board_usb_cleanup.
> * Rename board version of the function board_usb_cleanup to
> omap_xhci_board_usb_cleanup.
> Done only for boards that defines CONFIG_USB_XHCI_OMAP.
>
> Cc: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Uri Mashiach <uri.mashiach@compulab.co.il>
> Acked-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Roger Quadros <rogerq@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170508/76569d6d/attachment.sig>
next prev parent reply other threads:[~2017-05-08 19:39 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 13:39 [U-Boot] [PATCH v4 0/7] am57xx: cl-som-am57x: fix usb Uri Mashiach
2017-02-23 13:39 ` [U-Boot] [PATCH v4 1/7] arm: dra7xx: move CONFIG_DRA7XX to Kconfig Uri Mashiach
2017-02-26 15:16 ` Tom Rini
2017-05-08 19:38 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-23 13:39 ` [U-Boot] [PATCH v4 2/7] arm: usb: dra7xx: xHCI registers based on USB port index Uri Mashiach
2017-02-26 12:26 ` Marek Vasut
2017-02-26 15:16 ` Tom Rini
2017-02-27 16:14 ` Roger Quadros
2017-02-27 20:39 ` Marek Vasut
2017-02-27 20:38 ` Marek Vasut
2017-05-08 19:38 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-23 13:39 ` [U-Boot] [PATCH v4 3/7] usb: host: xhci-omap: fix double weak board_usb_init functions Uri Mashiach
2017-02-26 12:25 ` Igor Grinberg
2017-02-26 12:29 ` Marek Vasut
2017-02-27 16:22 ` Roger Quadros
2017-02-28 8:00 ` Uri Mashiach
2017-02-28 13:13 ` Roger Quadros
2017-03-01 9:12 ` Uri Mashiach
2017-03-01 15:13 ` Roger Quadros
2017-03-01 15:13 ` Roger Quadros
2017-05-08 19:39 ` Tom Rini [this message]
2017-02-23 13:39 ` [U-Boot] [PATCH v4 4/7] arm: am57xx: cl-som-am57x: invoke clock API to enable/disable clocks Uri Mashiach
2017-02-26 12:27 ` Marek Vasut
2017-02-27 16:24 ` Roger Quadros
2017-02-27 18:14 ` Marek Vasut
2017-05-08 19:39 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-23 13:39 ` [U-Boot] [PATCH v4 5/7] arm: am57xx: cl-som-am57x: fix USB scan Uri Mashiach
2017-05-08 19:39 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-23 13:39 ` [U-Boot] [PATCH v4 6/7] arm: am57xx: cl-som-am57x: enable USB storage Uri Mashiach
2017-05-08 19:39 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-23 13:39 ` [U-Boot] [PATCH v4 7/7] arm: am57xx: cl-som-am57x: enable USB commands Uri Mashiach
2017-05-08 19:39 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-04-23 8:18 ` [U-Boot] [PATCH v4 0/7] am57xx: cl-som-am57x: fix usb Uri Mashiach
2017-04-25 1:09 ` Tom Rini
2017-04-25 19:27 ` Marek Vasut
2017-05-04 7:05 ` Igor Grinberg
2017-05-04 10:08 ` Marek Vasut
2017-05-05 14:17 ` Tom Rini
2017-05-08 12:45 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508193929.GX12511@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox