From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 4/8] cmd/led.c: Remove unnecessary check on 'cmd' value
Date: Fri, 12 May 2017 13:23:58 -0400 [thread overview]
Message-ID: <20170512172358.GC5701@bill-the-cat> (raw)
In-Reply-To: <1494444018-2748-4-git-send-email-trini@konsulko.com>
On Wed, May 10, 2017 at 03:20:14PM -0400, Tom Rini wrote:
> We first check that if argc is less than 2 we return CMD_RET_USAGE. We
> then see if argc is greater than 2 and if so call get_led_cmd() to set
> 'cmd' and otherwise set it to LEDST_COUNT (which will always be positive
> as it's an enum with 0 already assigned). Therefore the test on if cmd
> is less than 0 will always be false and simply be omitted. Reported by
> clang-3.8.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170512/3d8a1cd7/attachment.sig>
next prev parent reply other threads:[~2017-05-12 17:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 19:20 [U-Boot] [PATCH 1/8] Kconfig: Drop CONFIG_EMAC_MDIO_PHY_NUM Tom Rini
2017-05-10 19:20 ` [U-Boot] [PATCH 2/8] cmd/bdinfo.c: Fix unused function warning Tom Rini
2017-05-12 17:23 ` [U-Boot] [U-Boot, " Tom Rini
2017-05-10 19:20 ` [U-Boot] [PATCH 3/8] cmd/io.c: Fix comparison of unsigned expression warning Tom Rini
2017-05-12 17:23 ` [U-Boot] [U-Boot, " Tom Rini
2017-05-10 19:20 ` [U-Boot] [PATCH 4/8] cmd/led.c: Remove unnecessary check on 'cmd' value Tom Rini
2017-05-12 17:23 ` Tom Rini [this message]
2017-05-10 19:20 ` [U-Boot] [PATCH 5/8] gpio-uclass.c: Fix comparison of unsigned expression warning Tom Rini
2017-05-10 22:03 ` Simon Glass
2017-05-12 17:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-05-10 19:20 ` [U-Boot] [PATCH 6/8] mmc: Change 'part_config' to be a u8 not char Tom Rini
2017-05-25 13:15 ` Jaehoon Chung
2017-05-10 19:20 ` [U-Boot] [PATCH 7/8] drivers/power/regulator/max77686.c: Fix comparisons of unsigned expressions Tom Rini
2017-05-25 13:17 ` Jaehoon Chung
2017-05-10 19:20 ` [U-Boot] [PATCH 8/8] tpm: Fix comparison of unsigned expression warning Tom Rini
2017-05-12 17:24 ` [U-Boot] [U-Boot, " Tom Rini
2017-05-12 17:23 ` [U-Boot] [U-Boot,1/8] Kconfig: Drop CONFIG_EMAC_MDIO_PHY_NUM Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170512172358.GC5701@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox