From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Tue, 16 May 2017 14:17:01 +0200 Subject: [U-Boot] [PATCHv6 25/28] net: sun7i_mac: Add read_rom_hwaddr hook In-Reply-To: <46bbb5cb-2960-2f05-9fc9-3b9e17c85e84@schinagl.nl> References: <20170515080244.21345-1-oliver@schinagl.nl> <20170515080244.21345-26-oliver@schinagl.nl> <20170515082257.drmb52n4ywguohlc@flea.home> <46bbb5cb-2960-2f05-9fc9-3b9e17c85e84@schinagl.nl> Message-ID: <20170516121701.fe2hbufuxlv72vma@flea.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, May 15, 2017 at 02:20:25PM +0200, Olliver Schinagl wrote: > Hey Maxime, > > On 15-05-17 10:22, Maxime Ripard wrote: > > On Mon, May 15, 2017 at 10:02:41AM +0200, Olliver Schinagl wrote: > > > With this patch sun7i_mac can now get the MAC address from the board in > > > a predetermined board specific manner. > > > > > > Signed-off-by: Olliver Schinagl > > > --- > > > drivers/net/Makefile | 2 +- > > > drivers/net/sun7i_mac.c | 2 ++ > > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/Makefile b/drivers/net/Makefile > > > index 86dee7d746..5df5567536 100644 > > > --- a/drivers/net/Makefile > > > +++ b/drivers/net/Makefile > > > @@ -23,7 +23,7 @@ obj-$(CONFIG_E1000) += e1000.o > > > obj-$(CONFIG_E1000_SPI) += e1000_spi.o > > > obj-$(CONFIG_EEPRO100) += eepro100.o > > > obj-$(CONFIG_SUN4I_EMAC) += sunxi_common.o sun4i_mac.o > > > -obj-$(CONFIG_SUN7I_MAC) += sun7i_mac.o > > > +obj-$(CONFIG_SUN7I_MAC) += sunxi_common.o sun7i_mac.o > > > > Shouldn't that be turned in a Kconfig option selected by both drivers? > What do you mean? There are some common functions that all of them share, > such as reading the MAC address. > > Or do you mean we should make the net_op rom_read_hwaddr() a configurable > Kconfig? I meant having a KConfig symbol to compile sunxi_common, and then have that symbol selected by the three EMAC/GMAC Kconfig symbol. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: