public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: dts: am335x: disable mmc3
Date: Wed, 17 May 2017 11:00:26 -0400	[thread overview]
Message-ID: <20170517150026.GS5701@bill-the-cat> (raw)
In-Reply-To: <d3c35cf0-f9a6-70ff-1165-6f008be35012@ti.com>

On Wed, May 17, 2017 at 04:46:29PM +0200, Jean-Jacques Hiblot wrote:
> 
> 
> On 17/05/2017 15:04, Tom Rini wrote:
> >On Wed, May 17, 2017 at 01:55:56PM +0200, Jean-Jacques Hiblot wrote:
> >
> >>SDIO is not supported in u-boot, there is no point in enabling mmc3.
> >>
> >>Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> >>---
> >>
> >>Tom,
> >>
> >>this will fix the problem youreported with commit b5511d6cb8dc601efc14b8cf60755
> >>on am335x-evm. For the record, the problem is that the clock of mmc 3 is not
> >>enbled by the arch code. With DM_MMC enabled, mmc3 gets probed and u-boot crashes
> >>when mmc3's registers are accessed for the first time.
> >>
> >>Jean-Jacques
> >>
> >>
> >>  arch/arm/dts/am335x-evm.dts | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >>diff --git a/arch/arm/dts/am335x-evm.dts b/arch/arm/dts/am335x-evm.dts
> >>index a6f20af..e94fcad 100644
> >>--- a/arch/arm/dts/am335x-evm.dts
> >>+++ b/arch/arm/dts/am335x-evm.dts
> >>@@ -721,12 +721,14 @@
> >>  };
> >>  &mmc3 {
> >>+	/* disable MMC3 as SDIO is not supported in U-Boot */
> >>+	status = "disabled";
> >>+
> >>  	/* these are on the crossbar and are outlined in the
> >>  	   xbar-event-map element */
> >>  	dmas = <&edma 12
> >>  		&edma 13>;
> >>  	dma-names = "tx", "rx";
> >>-	status = "okay";
> >>  	vmmc-supply = <&wlan_en_reg>;
> >>  	bus-width = <4>;
> >>  	pinctrl-names = "default";
> >Please put this into arch/arm/dts/am335x-evm-u-boot.dtsi instead,
> I tried and it doesn't work. The XXX-u-boot.dtsi being included at
> the beginning of the DTS, it cannot override the
> 'status = "okay"' present in am335x-evm.dts.

Ug, that's a problem.  I'm working on it then, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170517/c0f9b6d3/attachment.sig>

  reply	other threads:[~2017-05-17 15:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 11:55 [U-Boot] [PATCH] ARM: dts: am335x: disable mmc3 Jean-Jacques Hiblot
2017-05-17 13:04 ` Tom Rini
2017-05-17 14:46   ` Jean-Jacques Hiblot
2017-05-17 15:00     ` Tom Rini [this message]
2017-05-17 15:09       ` Jean-Jacques Hiblot
2017-05-17 16:01     ` Tom Rini
2017-05-17 16:14       ` Jean-Jacques Hiblot
2017-05-17 17:46         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170517150026.GS5701@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox