From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lothar =?UTF-8?B?V2HDn21hbm4=?= <LW@KARO-electronics.de>
Date: Wed, 31 May 2017 10:47:32 +0200
Subject: [U-Boot] [PATCH v2 3/6] GPT: add accessor function for disk GUID
In-Reply-To: <20170531094443.7a57e48d@jawa>
References: <20170526123845.GI10782@bill-the-cat>
 <1496076573-14495-1-git-send-email-alison@peloton-tech.com>
 <1496076573-14495-4-git-send-email-alison@peloton-tech.com>
 <20170531094443.7a57e48d@jawa>
Message-ID: <20170531104732.075604b7@karo-electronics.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

Hi,

On Wed, 31 May 2017 09:44:43 +0200 Lukasz Majewski wrote:
> Hi Alison,
>=20
> > From: Alison Chaiken <alison@she-devel.com>
> >=20
> > In order to read the GPT, modify the partition name strings, and then
> > write out a new GPT, the disk GUID is needed.  While there is an
> > existing accessor for the partition UUIDs, there is none yet for the
> > disk GUID.
>=20
> Acked-by: Lukasz Majewski <lukma@denx.de>
>=20
Did you read my comments on this patch in:
<20170530084651.545d9954@ipc1.ka-ro>
e.g.:
|> +		if (argc =3D=3D 5)
|> +		       strcpy(varname, argv[4]);
|> =20
|You didn't allocate any memory for varname and copy the argument string
|to a NULL pointer!
|Maybe use strdup() and free varname after use?



Lothar Wa=C3=9Fmann