* [U-Boot] [PATCH] edid: Fix gcc 7.1 warning
@ 2017-05-23 21:05 Jernej Skrabec
2017-05-24 1:00 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jernej Skrabec @ 2017-05-23 21:05 UTC (permalink / raw)
To: u-boot
This commit fixes the warning produced by gcc 7.1.
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
common/edid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/edid.c b/common/edid.c
index 19410aa4fc..854d40c8f8 100644
--- a/common/edid.c
+++ b/common/edid.c
@@ -295,7 +295,7 @@ static void edid_print_dtd(struct edid_monitor_descriptor *monitor,
h_total = h_active + h_blanking;
v_total = v_active + v_blanking;
- if (v_total * h_total)
+ if (v_total > 0 && h_total > 0)
vfreq = pixclock / (v_total * h_total);
else
vfreq = 1; /* Error case */
--
2.13.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] edid: Fix gcc 7.1 warning
2017-05-23 21:05 [U-Boot] [PATCH] edid: Fix gcc 7.1 warning Jernej Skrabec
@ 2017-05-24 1:00 ` Tom Rini
2017-05-24 4:35 ` Jernej Škrabec
2017-06-01 3:10 ` Simon Glass
2017-06-02 7:57 ` Anatolij Gustschin
2 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2017-05-24 1:00 UTC (permalink / raw)
To: u-boot
On Tue, May 23, 2017 at 11:05:30PM +0200, Jernej Skrabec wrote:
> This commit fixes the warning produced by gcc 7.1.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Reviewed-by: Tom Rini <trini@konsulko.com>
And I'm curious, where is your gcc-7.1 toolchain from, self built or
something else? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170523/85c47e2a/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] edid: Fix gcc 7.1 warning
2017-05-24 1:00 ` Tom Rini
@ 2017-05-24 4:35 ` Jernej Škrabec
2017-05-24 6:56 ` Peter Robinson
0 siblings, 1 reply; 6+ messages in thread
From: Jernej Škrabec @ 2017-05-24 4:35 UTC (permalink / raw)
To: u-boot
Hi,
Dne sreda, 24. maj 2017 ob 03:00:16 CEST je Tom Rini napisal(a):
> On Tue, May 23, 2017 at 11:05:30PM +0200, Jernej Skrabec wrote:
> > This commit fixes the warning produced by gcc 7.1.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> And I'm curious, where is your gcc-7.1 toolchain from, self built or
> something else? Thanks!
It's from Arch Linux repository.
I'm sorry to say that there seems to be something wrong with either gcc 7.1 or
bootp code. With OrangePi 2 board, bootp crashes and resets the board
(ethernet cable is not connected). I didn't have time to investigate it
further.
Best regards,
Jernej
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] edid: Fix gcc 7.1 warning
2017-05-24 4:35 ` Jernej Škrabec
@ 2017-05-24 6:56 ` Peter Robinson
0 siblings, 0 replies; 6+ messages in thread
From: Peter Robinson @ 2017-05-24 6:56 UTC (permalink / raw)
To: u-boot
On Wed, May 24, 2017 at 5:35 AM, Jernej Å krabec <jernej.skrabec@siol.net> wrote:
> Hi,
>
> Dne sreda, 24. maj 2017 ob 03:00:16 CEST je Tom Rini napisal(a):
>> On Tue, May 23, 2017 at 11:05:30PM +0200, Jernej Skrabec wrote:
>> > This commit fixes the warning produced by gcc 7.1.
>> >
>> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
>>
>> Reviewed-by: Tom Rini <trini@konsulko.com>
>>
>> And I'm curious, where is your gcc-7.1 toolchain from, self built or
>> something else? Thanks!
>
> It's from Arch Linux repository.
>
> I'm sorry to say that there seems to be something wrong with either gcc 7.1 or
> bootp code. With OrangePi 2 board, bootp crashes and resets the board
> (ethernet cable is not connected). I didn't have time to investigate it
> further.
I think we might have seen something similar with Fedora and gcc-7,
I'll ask some of the QA people and see if they can provide any more
details.
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] edid: Fix gcc 7.1 warning
2017-05-23 21:05 [U-Boot] [PATCH] edid: Fix gcc 7.1 warning Jernej Skrabec
2017-05-24 1:00 ` Tom Rini
@ 2017-06-01 3:10 ` Simon Glass
2017-06-02 7:57 ` Anatolij Gustschin
2 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2017-06-01 3:10 UTC (permalink / raw)
To: u-boot
On 23 May 2017 at 15:05, Jernej Skrabec <jernej.skrabec@siol.net> wrote:
> This commit fixes the warning produced by gcc 7.1.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> ---
>
> common/edid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] edid: Fix gcc 7.1 warning
2017-05-23 21:05 [U-Boot] [PATCH] edid: Fix gcc 7.1 warning Jernej Skrabec
2017-05-24 1:00 ` Tom Rini
2017-06-01 3:10 ` Simon Glass
@ 2017-06-02 7:57 ` Anatolij Gustschin
2 siblings, 0 replies; 6+ messages in thread
From: Anatolij Gustschin @ 2017-06-02 7:57 UTC (permalink / raw)
To: u-boot
On Tue, 23 May 2017 23:05:30 +0200
Jernej Skrabec jernej.skrabec at siol.net wrote:
> This commit fixes the warning produced by gcc 7.1.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> ---
>
> common/edid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to u-boot-video/master, thanks!
--
Anatolij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-02 7:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-23 21:05 [U-Boot] [PATCH] edid: Fix gcc 7.1 warning Jernej Skrabec
2017-05-24 1:00 ` Tom Rini
2017-05-24 4:35 ` Jernej Škrabec
2017-05-24 6:56 ` Peter Robinson
2017-06-01 3:10 ` Simon Glass
2017-06-02 7:57 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox