[U-Boot] [PATCH v2 5/6] rename GPT partitions to detect boot failure

Lukasz Majewski
2017-06-01T18:20:37Z

Hi Alison,

> Lukasz Majewski wrote:
>
> > Maybe it would be better to have
> >
> > gpt flip mmc 0 <optional parameter 'name'>
> >
> > (By default we have "primary" and "backup")
> >
> > In that way we could set other names to GPT partitions without the
> > need to modify the code.
>
> I answered:
>
> >> Another possibility is to support
> >>
> >> gpt flip mmc 0 <name 1> <name 2>
> >>
> >> where two names are required, with defaults 'primary' and
> >> 'backup'. Perhaps I should rework patch 5 that way?
>
> Lukasz responded:
>
> > Please correct my understanding if I'm wrong.
> >
> > You parse GPT partitions to a list and there are only two names
> > possible:
> >
> > "primary" and "backup".
> >
> > When we call gpt filp we rename those names ("primary" -> "backup"
> > and the other way).
> >
> > Ahhh..... so your patch would allow to rename "primary" to <name1>
> > and "backup" to <name2> for all names.
> >
> > My idea was rather to have a gpt call to set name of a GPT
> > partition....
>
> > I can image that somebody would like to change on the fly single GPT
> > partition name (when having/care about 2 partitions for his/her
> > project specific data).
> >
> > But, I don't know how much effort it would take to implement it
> > (and if others would see it beneficial).
>
> I would propose then two options:
>
> gpt rename mmc 0 <name 1> <name 2>
>
> which renames all the 1's to 2's, and
>
> gpt flip mmc 0 <name 1> <name 2>
>
> which swaps the two name strings for all partitions where they're
> found. These two operations together with 'gpt write' then cover all
> the common use cases I can imagine.

I think that this is enough. Let's wait for other's opinions (if
any).

>
> I'm open to any other suggestions, of course. I just posted what I
> already had to get started.
>
> -- Alison
>
> ---
> Alison Chaiken alison at she-devel.com,
> 650-279-5600 http://{ she-devel.com, exerciseforthereader.org }
> "We are giving up our privacy, one convenience at a time." --
> Evangelos Simoudis

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de