[U-Boot] [PATCH v2 3/6] GPT: add accessor function for disk GUID

Lothar Waßmann
2017-05-31T08:47:32Z

Hi,

On Wed, 31 May 2017 09:44:43 +0200 Lukasz Majewski wrote:
> Hi Alison,
>
> > From: Alison Chaiken <alison@she-devel.com>
> >
> > In order to read the GPT, modify the partition name strings, and then
> > write out a new GPT, the disk GUID is needed. While there is an
> > existing accessor for the partition UUIDs, there is none yet for the
> > disk GUID.
>
> Acked-by: Lukasz Majewski <lukma@denx.de>
>
Did you read my comments on this patch in:
<20170530084651.545d9954@ipc1.ka-ro>
e.g.:
|> + if (argc == 5)
|> + strcpy(varname, argv[4]);
|>
|You didn't allocate any memory for varname and copy the argument string
|to a NULL pointer!
|Maybe use strdup() and free varname after use?

Lothar WaÃŸmann