[U-Boot] [PATCH v2 5/6] rename GPT partitions to detect boot failure

Lukasz Majewski
2017-06-01T08:21:45Z

Hi Alison,

> On 2017-05-31 01:12, Lukasz Majewski wrote:
>
> [ SNIP ]
>
> > Maybe it would be better to have
> >
> > gpt flip mmc 0 <optional parameter 'name'>
> >
> > (By default we have "primary" and "backup")
> >
> > In that way we could set other names to GPT partitions without the
> > need to modify the code.
>
> Another possibility is to support
>
> gpt flip mmc 0 <name 1> <name 2>
>
> where two names are required, with defaults 'primary' and 'backup'.
> Perhaps I should rework patch 5 that way?

Please correct my understanding if I'm wrong.

You parse GPT partitions to a list and there are only two names
possible:

"primary" and "backup".

When we call gpt filp we rename those names ("primary" -> "backup" and
the other way).

Ahhh..... so your patch would allow to rename "primary" to <name1> and
"backup" to <name2> for all names.

My idea was rather to have a gpt call to set name of a GPT partition....

> I considered this form for
> the original submission, but wasn't sure what other projects might
> find useful.

I can image that somebody would like to change on the fly single GPT
partition name (when having/care about 2 partitions for his/her project
specific data).

But, I don't know how much effort it would take to implement it (and if
others would see it beneficial).

>
> > And another request -> Could you consider adding tests for those new
> > gpt commands to the 'sandbox' (sandbox_defconfig) ?
>
> I will look into adding another patch to do that. I'm sure such
> tests are a good idea for our project.

It is relatively easy to use sandbox to test some high level stuff
(like file systems, gpt, etc). One don't need HW for it.

>
> > Despite above comments - you did a great job :-)
>
> Thanks. I'm sorry to have omitted you, Lukasz, from the original
> submission, but I consulted an old version of MAINTAINERS from my
> original 2015.07.

It's Ok, don't worry. Things like that do happen....

>
> -- Alison
>
> ---
> Alison Chaiken alison at she-devel.com, 650-279-5600
> http://{ she-devel.com, exerciseforthereader.org }
> "We are giving up our privacy, one convenience at a time." --
> Evangelos Simoudis

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de