From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Tue, 13 Jun 2017 10:26:55 +0200 Subject: [U-Boot] [PATCH] mtd: nand: fsl_ifc: Fix handling of bitflips in erased pages In-Reply-To: <20170612015000.20285-1-darwin.dingel@alliedtelesis.co.nz> References: <20170612015000.20285-1-darwin.dingel@alliedtelesis.co.nz> Message-ID: <20170613082655.GA16532@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon 2017-06-12 13:50:00, Darwin Dingel wrote: > This is a fix made for the fsl_ifc_nand driver on linux kernel by > Pavel Machek and is applied to uboot. It is currently on applied on > linux-mtd. > > https://patchwork.kernel.org/patch/9758117/ > > IFC always raises ECC errors on erased pages. It is only ignored when > the buffer is checked for all 0xFF by is_blank(). The problem is a > single bitflip will cause is_blank() and then mtd_read to fail. The fix > makes use of nand_check_erased_ecc_chunk() to check for empty pages > instead of is_blank(). This also makes sure that reads are made at ECC > page size granularity to get a proper bitflip count. If the number of > bitflips does not exceed the ECC strength, the page is considered empty > and the bitflips will be corrected when data is sent to the higher > layers (e.g. ubi). Thanks for porting the fix in u-boot. I don't have hardware to test, but the fix looks good. Acked-by: Pavel Machek Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: