public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code
Date: Tue, 13 Jun 2017 09:06:17 +0200	[thread overview]
Message-ID: <20170613090617.381ef098@karo-electronics.de> (raw)
In-Reply-To: <CAPnjgZ2T0ARvrhvM83G6z+LtGUsGxytH6=z=_f-C9T07gJK0yg@mail.gmail.com>

Hi,

On Mon, 12 Jun 2017 17:50:45 -0600 Simon Glass wrote:
> On 8 June 2017 at 02:16, Lothar Waßmann <LW@karo-electronics.de> wrote:
> > Create exception stack in IRAM if available to facilitate debugging of
> > pre-relocation code by catching exceptions rather than stopping dead.
> >
> > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> > ---
> >  arch/arm/lib/vectors.S | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> But please see below.
> 
> >
> > diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
> > index f53b1e9..1019091 100644
> > --- a/arch/arm/lib/vectors.S
> > +++ b/arch/arm/lib/vectors.S
> > @@ -117,7 +117,6 @@ data_abort:
> >  not_used:
> >  irq:
> >  fiq:
> > -
> 
> What is this?
> 
Ooops. An unintentionally deleted empty line.
Should I resend the patch, or can you fix it up when applying?


Lothar Waßmann

  reply	other threads:[~2017-06-13  7:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08  8:16 [U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code Lothar Waßmann
2017-06-12 22:44 ` [U-Boot] " Tom Rini
2017-06-12 23:50 ` [U-Boot] [PATCH] " Simon Glass
2017-06-13  7:06   ` Lothar Waßmann [this message]
2017-06-17  3:41     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170613090617.381ef098@karo-electronics.de \
    --to=lw@karo-electronics.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox