* [U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code
@ 2017-06-08 8:16 Lothar Waßmann
2017-06-12 22:44 ` [U-Boot] " Tom Rini
2017-06-12 23:50 ` [U-Boot] [PATCH] " Simon Glass
0 siblings, 2 replies; 5+ messages in thread
From: Lothar Waßmann @ 2017-06-08 8:16 UTC (permalink / raw)
To: u-boot
Create exception stack in IRAM if available to facilitate debugging of
pre-relocation code by catching exceptions rather than stopping dead.
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
arch/arm/lib/vectors.S | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
index f53b1e9..1019091 100644
--- a/arch/arm/lib/vectors.S
+++ b/arch/arm/lib/vectors.S
@@ -117,7 +117,6 @@ data_abort:
not_used:
irq:
fiq:
-
1:
bl 1b /* hang and never return */
@@ -126,7 +125,11 @@ fiq:
/* IRQ stack memory (calculated at run-time) + 8 bytes */
.globl IRQ_STACK_START_IN
IRQ_STACK_START_IN:
+#ifdef IRAM_BASE_ADDR
+ .word IRAM_BASE_ADDR + 0x20
+#else
.word 0x0badc0de
+#endif
@
@ IRQ stack frame.
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] ARM: provide a valid exception stack address for startup code
2017-06-08 8:16 [U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code Lothar Waßmann
@ 2017-06-12 22:44 ` Tom Rini
2017-06-12 23:50 ` [U-Boot] [PATCH] " Simon Glass
1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2017-06-12 22:44 UTC (permalink / raw)
To: u-boot
On Thu, Jun 08, 2017 at 10:16:36AM +0200, Lothar Waßmann wrote:
> Create exception stack in IRAM if available to facilitate debugging of
> pre-relocation code by catching exceptions rather than stopping dead.
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170612/b34c6a0c/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code
2017-06-08 8:16 [U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code Lothar Waßmann
2017-06-12 22:44 ` [U-Boot] " Tom Rini
@ 2017-06-12 23:50 ` Simon Glass
2017-06-13 7:06 ` Lothar Waßmann
1 sibling, 1 reply; 5+ messages in thread
From: Simon Glass @ 2017-06-12 23:50 UTC (permalink / raw)
To: u-boot
On 8 June 2017 at 02:16, Lothar Waßmann <LW@karo-electronics.de> wrote:
> Create exception stack in IRAM if available to facilitate debugging of
> pre-relocation code by catching exceptions rather than stopping dead.
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
> arch/arm/lib/vectors.S | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
But please see below.
>
> diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
> index f53b1e9..1019091 100644
> --- a/arch/arm/lib/vectors.S
> +++ b/arch/arm/lib/vectors.S
> @@ -117,7 +117,6 @@ data_abort:
> not_used:
> irq:
> fiq:
> -
What is this?
> 1:
> bl 1b /* hang and never return */
>
> @@ -126,7 +125,11 @@ fiq:
> /* IRQ stack memory (calculated at run-time) + 8 bytes */
> .globl IRQ_STACK_START_IN
> IRQ_STACK_START_IN:
> +#ifdef IRAM_BASE_ADDR
> + .word IRAM_BASE_ADDR + 0x20
> +#else
> .word 0x0badc0de
> +#endif
>
> @
> @ IRQ stack frame.
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code
2017-06-12 23:50 ` [U-Boot] [PATCH] " Simon Glass
@ 2017-06-13 7:06 ` Lothar Waßmann
2017-06-17 3:41 ` Simon Glass
0 siblings, 1 reply; 5+ messages in thread
From: Lothar Waßmann @ 2017-06-13 7:06 UTC (permalink / raw)
To: u-boot
Hi,
On Mon, 12 Jun 2017 17:50:45 -0600 Simon Glass wrote:
> On 8 June 2017 at 02:16, Lothar Waßmann <LW@karo-electronics.de> wrote:
> > Create exception stack in IRAM if available to facilitate debugging of
> > pre-relocation code by catching exceptions rather than stopping dead.
> >
> > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> > ---
> > arch/arm/lib/vectors.S | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> But please see below.
>
> >
> > diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
> > index f53b1e9..1019091 100644
> > --- a/arch/arm/lib/vectors.S
> > +++ b/arch/arm/lib/vectors.S
> > @@ -117,7 +117,6 @@ data_abort:
> > not_used:
> > irq:
> > fiq:
> > -
>
> What is this?
>
Ooops. An unintentionally deleted empty line.
Should I resend the patch, or can you fix it up when applying?
Lothar Waßmann
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code
2017-06-13 7:06 ` Lothar Waßmann
@ 2017-06-17 3:41 ` Simon Glass
0 siblings, 0 replies; 5+ messages in thread
From: Simon Glass @ 2017-06-17 3:41 UTC (permalink / raw)
To: u-boot
+Tom
On 13 June 2017 at 01:06, Lothar Waßmann <LW@karo-electronics.de> wrote:
> Hi,
>
> On Mon, 12 Jun 2017 17:50:45 -0600 Simon Glass wrote:
>> On 8 June 2017 at 02:16, Lothar Waßmann <LW@karo-electronics.de> wrote:
>> > Create exception stack in IRAM if available to facilitate debugging of
>> > pre-relocation code by catching exceptions rather than stopping dead.
>> >
>> > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
>> > ---
>> > arch/arm/lib/vectors.S | 5 ++++-
>> > 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>
>> But please see below.
>>
>> >
>> > diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
>> > index f53b1e9..1019091 100644
>> > --- a/arch/arm/lib/vectors.S
>> > +++ b/arch/arm/lib/vectors.S
>> > @@ -117,7 +117,6 @@ data_abort:
>> > not_used:
>> > irq:
>> > fiq:
>> > -
>>
>> What is this?
>>
> Ooops. An unintentionally deleted empty line.
> Should I resend the patch, or can you fix it up when applying?
Probably the latter, but it's up to the custodian.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-17 3:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-08 8:16 [U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code Lothar Waßmann
2017-06-12 22:44 ` [U-Boot] " Tom Rini
2017-06-12 23:50 ` [U-Boot] [PATCH] " Simon Glass
2017-06-13 7:06 ` Lothar Waßmann
2017-06-17 3:41 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox