From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2] ARM: rmobile: Add missing config bits after resync
Date: Tue, 20 Jun 2017 14:30:00 -0400 [thread overview]
Message-ID: <20170620183000.GB27196@bill-the-cat> (raw)
In-Reply-To: <4c2b4b68-95d1-bc77-7a9e-d3ad0793958d@gmail.com>
On Tue, Jun 20, 2017 at 08:22:15PM +0200, Marek Vasut wrote:
> On 06/20/2017 08:06 PM, Tom Rini wrote:
> > From: Marek Vasut <marek.vasut@gmail.com>
> >
> > The commit "fb82fe385173 configs: Resync defconfigs" broke all Gen3
> > boards by removing config options from the config which are needed
> > for correct build. Reinstate those.
> >
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> > Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>
> Please keep the CONFIG_R8A7795=y for consistency's sake.
Nope, please correct your Kconfig entry for consistency's sake (in this
case, default R8A7795 rather than it just being the first entry). You
cannot rely on X being set in the defconfig file to enforce Y happening,
you use the Kconfig files for that. configs/ content is regnerated.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170620/67712ab0/attachment.sig>
next prev parent reply other threads:[~2017-06-20 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 13:17 [U-Boot] [PATCH] ARM: rmobile: Add missing config bits after resync Marek Vasut
2017-06-20 18:06 ` [U-Boot] [PATCHv2] " Tom Rini
2017-06-20 18:22 ` Marek Vasut
2017-06-20 18:30 ` Tom Rini [this message]
2017-06-20 18:32 ` [U-Boot] [PATCHv3] ARM: rmobile: Add missing config bits Tom Rini
2017-06-20 18:35 ` Marek Vasut
2017-06-20 18:38 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620183000.GB27196@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox