From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Wed, 21 Jun 2017 09:31:49 +0200 Subject: [U-Boot] [PATCH 10/14] dm: mmc: sunxi: Add support for driver model In-Reply-To: <20170619171131.185337-11-sjg@chromium.org> References: <20170619171131.185337-1-sjg@chromium.org> <20170619171131.185337-11-sjg@chromium.org> Message-ID: <20170621073149.caej77igvm5mdou2@flea.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On Mon, Jun 19, 2017 at 11:11:27AM -0600, Simon Glass wrote: > Add a driver-model version of this driver which mostly uses the existing > code. The old code can be removed once all boards are switched over. > > Signed-off-by: Simon Glass I'm not sure if you tested that, but we have some code that switches the MMC indices when using both an eMMC and an external MMC. http://git.denx.de/?p=u-boot.git;a=blob;f=board/sunxi/board.c#l494 This predates my time, but it seems that it was done to have a consistent boot MMC device ID. I'm not really sure we can get rid of it (even if it creates some issues of it's own), but what would be the impact of a switch to the device model on that logic? Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: