[U-Boot] [PATCHv2] powerpc: Restore core of mpc8xx

[Wolfgang Denk <wd@denx.de>]

Dear Tom,

In message <1498058762-1909-1-git-send-email-trini@konsulko.com> you wrote:
> 
> Please fill me in better with v3.  I squahed the previous 1-10 into a
> single commit that brings back the core of mpc8xx.  Please add an entry
> to MAINTAINERS for yourself for mpc8xx and do a travis-ci build and see
> if we really need to bring back commproc.h to the ppc4xx files as well.
> -- Tom
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
>  .travis.yml                            |    2 +
>  MAINTAINERS                            |    6 -
>  README                                 |  104 ++-
>  api/api_platform-powerpc.c             |    3 +-
>  arch/powerpc/Kconfig                   |    4 +
>  arch/powerpc/cpu/mpc8xx/Kconfig        |   13 +
>  arch/powerpc/cpu/mpc8xx/Makefile       |   25 +
>  arch/powerpc/cpu/mpc8xx/bedbug_860.c   |  314 ++++++++
>  arch/powerpc/cpu/mpc8xx/config.mk      |    8 +
>  arch/powerpc/cpu/mpc8xx/cpu.c          |  580 +++++++++++++
>  arch/powerpc/cpu/mpc8xx/cpu_init.c     |  218 +++++
>  arch/powerpc/cpu/mpc8xx/fdt.c          |   27 +
>  arch/powerpc/cpu/mpc8xx/fec.c          |  933 +++++++++++++++++++++
>  arch/powerpc/cpu/mpc8xx/fec.h          |   12 +
>  arch/powerpc/cpu/mpc8xx/interrupts.c   |  278 +++++++
>  arch/powerpc/cpu/mpc8xx/kgdb.S         |   54 ++
>  arch/powerpc/cpu/mpc8xx/plprcr_write.S |  119 +++
>  arch/powerpc/cpu/mpc8xx/scc.c          |  472 +++++++++++
>  arch/powerpc/cpu/mpc8xx/serial.c       |  676 ++++++++++++++++
>  arch/powerpc/cpu/mpc8xx/speed.c        |  385 +++++++++
>  arch/powerpc/cpu/mpc8xx/spi.c          |  533 ++++++++++++
>  arch/powerpc/cpu/mpc8xx/start.S        |  650 +++++++++++++++
>  arch/powerpc/cpu/mpc8xx/traps.c        |  216 +++++
>  arch/powerpc/cpu/mpc8xx/upatch.c       |  194 +++++
>  arch/powerpc/cpu/mpc8xx/video.c        | 1123 ++++++++++++++++++++++++++
>  arch/powerpc/cpu/ppc4xx/4xx_uart.c     |    1 +
>  arch/powerpc/cpu/ppc4xx/interrupts.c   |    1 +
>  arch/powerpc/cpu/ppc4xx/miiphy.c       |    1 +
>  arch/powerpc/cpu/ppc4xx/uic.c          |    1 +
>  arch/powerpc/cpu/ppc4xx/xilinx_irq.c   |    1 +
>  arch/powerpc/include/asm/8xx_immap.h   |  515 ++++++++++++
>  arch/powerpc/include/asm/cache.h       |   41 +-
>  arch/powerpc/include/asm/global_data.h |    3 +
>  arch/powerpc/include/asm/iopin_8xx.h   |  379 +++++++++
>  arch/powerpc/include/asm/ppc.h         |   15 +
>  arch/powerpc/include/asm/processor.h   |   17 +-
>  arch/powerpc/include/asm/status_led.h  |   73 ++
>  arch/powerpc/lib/Makefile              |    1 +
>  arch/powerpc/lib/ide.c                 |  184 +++++
>  arch/powerpc/lib/ide.h                 |   15 +
>  arch/powerpc/lib/immap.c               |  564 +++++++++++++
>  arch/powerpc/lib/time.c                |   11 +
>  cmd/bdinfo.c                           |    3 +-
>  cmd/bedbug.c                           |    4 +
>  cmd/ide.c                              |    9 +-
>  cmd/pcmcia.c                           |    4 +
>  cmd/reginfo.c                          |   59 +-
>  cmd/source.c                           |    3 +
>  common/board_f.c                       |    5 +-
>  common/board_r.c                       |   14 +
>  common/bootm_os.c                      |   14 +-
>  common/lcd.c                           |    4 +
>  doc/README.MPC866                      |   24 +
>  doc/README.fsl-clk                     |    5 +
>  doc/README.scrapyard                   |    1 +
>  drivers/block/ide.c                    |   11 +
>  drivers/block/sil680.c                 |    1 +
>  drivers/bootcount/bootcount.c          |    5 +
>  drivers/i2c/i2c_core.c                 |   11 +
>  drivers/i2c/soft_i2c.c                 |    4 +
>  drivers/net/4xx_enet.c                 |    1 +
>  drivers/pcmcia/Makefile                |    1 +
>  drivers/pcmcia/mpc8xx_pcmcia.c         |  258 ++++++
>  drivers/rtc/Makefile                   |    1 +
>  drivers/rtc/mpc8xx.c                   |   60 ++
>  drivers/serial/serial.c                |    3 -
>  drivers/usb/gadget/Makefile            |    1 +
>  drivers/usb/gadget/mpc8xx_udc.c        | 1386 ++++++++++++++++++++++++++++++++
>  drivers/video/Makefile                 |    1 +
>  drivers/video/mpc8xx_lcd.c             |  400 +++++++++
>  examples/standalone/Makefile           |    2 +
>  examples/standalone/test_burst.c       |  284 +++++++
>  examples/standalone/test_burst.h       |   22 +
>  examples/standalone/test_burst_lib.S   |  154 ++++
>  examples/standalone/timer.c            |  333 ++++++++
>  include/asm-generic/global_data.h      |    2 +-
>  include/asm-generic/u-boot.h           |    3 +-
>  include/commproc.h                     |  791 ++++++++++++++++++
>  include/configs/CPCI4052.h             |    1 +
>  include/configs/MIP405.h               |    1 +
>  include/configs/PIP405.h               |    1 +
>  include/configs/PLU405.h               |    1 +
>  include/i2c.h                          |   24 +-
>  include/lcd.h                          |    4 +-
>  include/mpc823_lcd.h                   |   44 +
>  include/net.h                          |    4 +
>  include/pcmcia.h                       |   16 +-
>  include/post.h                         |    7 +-
>  include/ppc_asm.tmpl                   |   46 ++
>  include/usb/mpc8xx_udc.h               |  178 ++++
>  include/watchdog.h                     |    5 +
>  post/Makefile                          |    1 +
>  post/cpu/mpc8xx/Makefile               |    9 +
>  post/cpu/mpc8xx/cache.c                |   62 ++
>  post/cpu/mpc8xx/cache_8xx.S            |  477 +++++++++++
>  post/cpu/mpc8xx/ether.c                |  530 ++++++++++++
>  post/cpu/mpc8xx/spr.c                  |  132 +++
>  post/cpu/mpc8xx/uart.c                 |  508 ++++++++++++
>  post/cpu/mpc8xx/usb.c                  |  249 ++++++
>  post/cpu/mpc8xx/watchdog.c             |   59 ++
>  post/tests.c                           |   12 +
>  scripts/config_whitelist.txt           |   62 +-
>  102 files changed, 15035 insertions(+), 54 deletions(-)

I think we should not simply re-add the old mess, but clean ip up
before.  Also, we should only add things that are stilkl needed and
will be actively tested and maintained.

Alll the 4xx stuff has no place here and should be thrown out.

File structure should be cleaned up - drivers should be placed where
they belong.

Stuff that is most certainly unmaintained and/or broken (bedbug
support, test_burst, PCMCIA support, USB support) should be omitted
as well.

We should not re-add this stuff, but clean up at least these things
before.


Actually I also agree with Heiko that we should fix things like
(lack of) using I/O accessors before re-adding the code.  Most
modern compilers will most likely generate incorrect code in a large
number of places - this has only gone unnoticed for a long time due
to lack of testers.


I have to admit that it is kind of breaking my heart to see 8xx go,
as this is where it all started - this was the first code of this
project, long before the name U-Boot came up.  But formally I'm
still maintainer of this code, and in it's current form I want to
see it removed and gone.  If we re-add it, it really has to meet
today's standards.

NAK!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
An Ada exception is when a routine gets in trouble and says
'Beam me up, Scotty'.