public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] usb: increase usb delay
@ 2017-06-24 23:09 Rob Clark
  2017-06-26 14:22 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Clark @ 2017-06-24 23:09 UTC (permalink / raw)
  To: u-boot

This makes booting off the USB disks I have go from 50% reliable to 100%
reliable.  I'm no USB expert so maybe there is a better way.  But one
way or another we aren't waiting long enough after power-on for the
usb device to be ready.

Signed-off-by: Rob Clark <robdclark@gmail.com>
---
 common/usb_storage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/usb_storage.c b/common/usb_storage.c
index 03171f7..0e3de90 100644
--- a/common/usb_storage.c
+++ b/common/usb_storage.c
@@ -1019,7 +1019,7 @@ static int usb_test_unit_ready(ccb *srb, struct us_data *ss)
 		if ((srb->sense_buf[2] == 0x02) &&
 		    (srb->sense_buf[12] == 0x3a))
 			return -1;
-		mdelay(100);
+		mdelay(250);
 	} while (retries--);
 
 	return -1;
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] usb: increase usb delay
  2017-06-24 23:09 [U-Boot] [PATCH] usb: increase usb delay Rob Clark
@ 2017-06-26 14:22 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2017-06-26 14:22 UTC (permalink / raw)
  To: u-boot

On Sat, Jun 24, 2017 at 07:09:32PM -0400, Rob Clark wrote:

> This makes booting off the USB disks I have go from 50% reliable to 100%
> reliable.  I'm no USB expert so maybe there is a better way.  But one
> way or another we aren't waiting long enough after power-on for the
> usb device to be ready.
> 
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
>  common/usb_storage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/usb_storage.c b/common/usb_storage.c
> index 03171f7..0e3de90 100644
> --- a/common/usb_storage.c
> +++ b/common/usb_storage.c
> @@ -1019,7 +1019,7 @@ static int usb_test_unit_ready(ccb *srb, struct us_data *ss)
>  		if ((srb->sense_buf[2] == 0x02) &&
>  		    (srb->sense_buf[12] == 0x3a))
>  			return -1;
> -		mdelay(100);
> +		mdelay(250);
>  	} while (retries--);
>  
>  	return -1;

This made me think of 1c3e62d690a3 which was the result of other USB
delay decreasing changes.  Perhaps there's some issues on the host
controller code used on dragonboard?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170626/7c64cbc5/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-26 14:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-24 23:09 [U-Boot] [PATCH] usb: increase usb delay Rob Clark
2017-06-26 14:22 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox