From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: increase usb delay
Date: Mon, 26 Jun 2017 10:22:49 -0400 [thread overview]
Message-ID: <20170626142249.GH27196@bill-the-cat> (raw)
In-Reply-To: <20170624230932.3607-1-robdclark@gmail.com>
On Sat, Jun 24, 2017 at 07:09:32PM -0400, Rob Clark wrote:
> This makes booting off the USB disks I have go from 50% reliable to 100%
> reliable. I'm no USB expert so maybe there is a better way. But one
> way or another we aren't waiting long enough after power-on for the
> usb device to be ready.
>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
> common/usb_storage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/usb_storage.c b/common/usb_storage.c
> index 03171f7..0e3de90 100644
> --- a/common/usb_storage.c
> +++ b/common/usb_storage.c
> @@ -1019,7 +1019,7 @@ static int usb_test_unit_ready(ccb *srb, struct us_data *ss)
> if ((srb->sense_buf[2] == 0x02) &&
> (srb->sense_buf[12] == 0x3a))
> return -1;
> - mdelay(100);
> + mdelay(250);
> } while (retries--);
>
> return -1;
This made me think of 1c3e62d690a3 which was the result of other USB
delay decreasing changes. Perhaps there's some issues on the host
controller code used on dragonboard? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170626/7c64cbc5/attachment.sig>
prev parent reply other threads:[~2017-06-26 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 23:09 [U-Boot] [PATCH] usb: increase usb delay Rob Clark
2017-06-26 14:22 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626142249.GH27196@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox