public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 02/18] common: env_nand: use get_nand_dev_by_index()
Date: Mon, 26 Jun 2017 19:12:52 -0500	[thread overview]
Message-ID: <20170627001308.23513-3-grygorii.strashko@ti.com> (raw)
In-Reply-To: <20170627001308.23513-1-grygorii.strashko@ti.com>

As part of preparation for nand DM conversion the new API has been
introduced to remove direct access to nand_info array. So, use it here
instead of accessing to nand_info array directly.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 common/env_nand.c | 33 +++++++++++++++++++++------------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/common/env_nand.c b/common/env_nand.c
index 2e28171..133ecfb 100644
--- a/common/env_nand.c
+++ b/common/env_nand.c
@@ -130,17 +130,22 @@ static int writeenv(size_t offset, u_char *buf)
 	size_t end = offset + CONFIG_ENV_RANGE;
 	size_t amount_saved = 0;
 	size_t blocksize, len;
+	struct mtd_info *mtd;
 	u_char *char_ptr;
 
-	blocksize = nand_info[0]->erasesize;
+	mtd = get_nand_dev_by_index(0);
+	if (!mtd)
+		return 1;
+
+	blocksize = mtd->erasesize;
 	len = min(blocksize, (size_t)CONFIG_ENV_SIZE);
 
 	while (amount_saved < CONFIG_ENV_SIZE && offset < end) {
-		if (nand_block_isbad(nand_info[0], offset)) {
+		if (nand_block_isbad(mtd, offset)) {
 			offset += blocksize;
 		} else {
 			char_ptr = &buf[amount_saved];
-			if (nand_write(nand_info[0], offset, &len, char_ptr))
+			if (nand_write(mtd, offset, &len, char_ptr))
 				return 1;
 
 			offset += blocksize;
@@ -161,13 +166,15 @@ struct env_location {
 static int erase_and_write_env(const struct env_location *location,
 		u_char *env_new)
 {
+	struct mtd_info *mtd;
 	int ret = 0;
 
-	if (!nand_info[0])
+	mtd = get_nand_dev_by_index(0);
+	if (!mtd)
 		return 1;
 
 	printf("Erasing %s...\n", location->name);
-	if (nand_erase_opts(nand_info[0], &location->erase_opts))
+	if (nand_erase_opts(mtd, &location->erase_opts))
 		return 1;
 
 	printf("Writing to %s... ", location->name);
@@ -248,22 +255,24 @@ static int readenv(size_t offset, u_char *buf)
 	size_t end = offset + CONFIG_ENV_RANGE;
 	size_t amount_loaded = 0;
 	size_t blocksize, len;
+	struct mtd_info *mtd;
 	u_char *char_ptr;
 
-	if (!nand_info[0])
+	mtd = get_nand_dev_by_index(0);
+	if (!mtd)
 		return 1;
 
-	blocksize = nand_info[0]->erasesize;
+	blocksize = mtd->erasesize;
 	len = min(blocksize, (size_t)CONFIG_ENV_SIZE);
 
 	while (amount_loaded < CONFIG_ENV_SIZE && offset < end) {
-		if (nand_block_isbad(nand_info[0], offset)) {
+		if (nand_block_isbad(mtd, offset)) {
 			offset += blocksize;
 		} else {
 			char_ptr = &buf[amount_loaded];
-			if (nand_read_skip_bad(nand_info[0], offset,
+			if (nand_read_skip_bad(mtd, offset,
 					       &len, NULL,
-					       nand_info[0]->size, char_ptr))
+					       mtd->size, char_ptr))
 				return 1;
 
 			offset += blocksize;
@@ -390,12 +399,12 @@ void env_relocate_spec(void)
 	ALLOC_CACHE_ALIGN_BUFFER(char, buf, CONFIG_ENV_SIZE);
 
 #if defined(CONFIG_ENV_OFFSET_OOB)
+	struct mtd_info *mtd  = get_nand_dev_by_index(0);
 	/*
 	 * If unable to read environment offset from NAND OOB then fall through
 	 * to the normal environment reading code below
 	 */
-	if (nand_info[0] && !get_nand_env_oob(nand_info[0],
-					      &nand_env_oob_offset)) {
+	if (mtd && !get_nand_env_oob(mtd, &nand_env_oob_offset)) {
 		printf("Found Environment offset in OOB..\n");
 	} else {
 		set_default_env("!no env offset in OOB");
-- 
2.10.1

  parent reply	other threads:[~2017-06-27  0:12 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27  0:12 [U-Boot] [PATCH v4 00/17] nand: remove direct acces to nand_info array Grygorii Strashko
2017-06-27  0:12 ` [U-Boot] [PATCH v4 01/18] cmd: nand: abstract global variable usage for dm conversion Grygorii Strashko
2017-07-07  3:58   ` Simon Glass
2017-07-08  0:32     ` Grygorii Strashko
2017-07-08 16:08       ` Simon Glass
2017-07-08 18:32         ` Grygorii Strashko
2017-07-12 12:14   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:12 ` Grygorii Strashko [this message]
2017-07-12 12:14   ` [U-Boot] [U-Boot, v4, 02/18] common: env_nand: use get_nand_dev_by_index() Tom Rini
2017-06-27  0:12 ` [U-Boot] [PATCH v4 03/18] dfu: dfu_nand: " Grygorii Strashko
2017-07-12 12:14   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:12 ` [U-Boot] [PATCH v4 04/18] cmd: bootm: " Grygorii Strashko
2017-07-12 12:14   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:12 ` [U-Boot] [PATCH v4 05/18] cmd: jffs2: " Grygorii Strashko
2017-07-12 12:14   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:12 ` [U-Boot] [PATCH v4 06/18] common: " Grygorii Strashko
2017-07-12 12:14   ` [U-Boot] [U-Boot,v4,06/18] " Tom Rini
2017-06-27  0:12 ` [U-Boot] [PATCH v4 07/18] fs: " Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot,v4,07/18] " Tom Rini
2017-06-27  0:12 ` [U-Boot] [PATCH v4 08/18] cmd: nand: remove direct access to struct mtd_info->priv Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:12 ` [U-Boot] [PATCH v4 09/18] net: phy: cortina: use get_nand_dev_by_index() Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:13 ` [U-Boot] [PATCH v4 10/18] net: fm: " Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:13 ` [U-Boot] [PATCH v4 11/18] mtd: nand: drv: " Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:13 ` [U-Boot] [PATCH v4 12/18] cmd: mvebu: bubt: " Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:13 ` [U-Boot] [PATCH v4 13/18] board: atmel: " Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:13 ` [U-Boot] [PATCH v4 14/18] board: ronetix: " Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:13 ` [U-Boot] [PATCH v4 15/18] board: BuR: " Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:13 ` [U-Boot] [PATCH v4 16/18] board: toradex: " Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:13 ` [U-Boot] [PATCH v4 17/18] armv8: fsl-layerscape: " Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-06-27  0:13 ` [U-Boot] [PATCH v4 18/18] mtd: nand: make nand_info array static Grygorii Strashko
2017-07-12 12:15   ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-07-02 12:41 ` [U-Boot] [PATCH v4 00/17] nand: remove direct acces to nand_info array Tom Rini
2017-07-03  6:00   ` Lokesh Vutla
2017-07-03 11:17     ` Tom Rini
2017-07-04  6:13       ` Lokesh Vutla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170627001308.23513-3-grygorii.strashko@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox