[U-Boot] [PATCH V7 4/4] rockchip: rk3288: enable rockusb support on rk3288 based device

Lukasz Majewski
2017-06-30T08:15:30Z

Hi Eddie,

> 2017-06-29 18:49 GMT+08:00 Lukasz Majewski <lukma@denx.de>:
> > On Thu, 29 Jun 2017 08:44:47 +0800
> > Eddie Cai <eddie.cai.linux@gmail.com> wrote:
> >
> >> >
> >> > The issue is not with this one particular board.
> >> >
> >> > I'm concerned, since your patch set causes build errors for other
> >> > boards.
> >> >
> >> > Can you build test (with travis-CI) your patches and check if you
> >> > can reproduce those errors?
> >> I can reproduce this error with travis-CI. but i can't not
> >> reproduce this rk3036 board error on my desktop.
> >> can you try to local build rk3036 board and see if can reproduce
> >> this error?
> >> >
> > The rk3036 (evb-rk3036_defconfig) builds fine (with my old 4.8
> > gcc).
> >
> > However, your patches cause other issues [1]:
> > https://travis-ci.org/lmajewski/u-boot-dfu/jobs/248264628
> >
> > And for example I can reproduce the issue on
> > rock2_defconfig at my local PC.
> >
> > Can you build rock2 on your PC with your patches applied without any
> > issues?
> I reproduced and fixed this issue long time ago. I didn't send my
> next version because i don't know how to reproduce 3036 issue. It
> looks like 3036 work fine on your side now. Can i ignore this 3036
> issue?

Please before posting next version make sure that no build breaks
shows up in TravisCI.

Please as a reference use mainline .travis.yml. (especially build for
rockchip)

Please let me know if you need any assistance at fixing problems.

> >
> >
> >
> >
> >
> > [1] The "testing" tree can be found at:
> > https://github.com/lmajewski/u-boot-dfu/tree/testing
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH, Managing Director: Wolfgang
> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> > wd at denx.de

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de