From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <lukma@denx.de>
Date: Fri, 30 Jun 2017 10:15:30 +0200
Subject: [U-Boot] [PATCH V7 4/4] rockchip: rk3288: enable rockusb
 support on rk3288 based device
In-Reply-To: <CAJrj+DP16YbG1mQ3EWgG=RB4XHv=Ci0dHt+wx+9DMB_9ZOzhAg@mail.gmail.com>
References: <1495702234-29546-1-git-send-email-eddie.cai.linux@gmail.com>
 <1495702234-29546-5-git-send-email-eddie.cai.linux@gmail.com>
 <20170529095123.69386562@jawa>
 <CAJrj+DNSyL-SLYTyd8CYtX0E5ak=RJSJWvP3odoC=Leh-=67Sg@mail.gmail.com>
 <20170531091252.7b04f134@jawa>
 <CAJrj+DO2x+RF+B=LJBjcYh00Q8K7XNvYhqYepDqxo3giQeG-=g@mail.gmail.com>
 <20170603162356.2159815a@jawa> <20170621094422.447100b8@jawa>
 <CAJrj+DMD+pG+QHv=T7F+NnHoPGGhPqw6cADkQb56E_Znuu--bQ@mail.gmail.com>
 <20170628095546.416032d5@jawa>
 <CAJrj+DNRo_pfanoZQThnP3mc+Te_7Pb9wxKSJoHTQ7-CCPr3TA@mail.gmail.com>
 <20170629124919.599b79d0@jawa>
 <CAJrj+DP16YbG1mQ3EWgG=RB4XHv=Ci0dHt+wx+9DMB_9ZOzhAg@mail.gmail.com>
Message-ID: <20170630101530.78ab1406@jawa>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Eddie,

> 2017-06-29 18:49 GMT+08:00 Lukasz Majewski <lukma@denx.de>:
> > On Thu, 29 Jun 2017 08:44:47 +0800
> > Eddie Cai <eddie.cai.linux@gmail.com> wrote:
> >
> >> >
> >> > The issue is not with this one particular board.
> >> >
> >> > I'm concerned, since your patch set causes build errors for other
> >> > boards.
> >> >
> >> > Can you build test (with travis-CI) your patches and check if you
> >> > can reproduce those errors?
> >> I can reproduce this error with travis-CI. but i can't not
> >> reproduce this rk3036 board error on my desktop.
> >> can you try to local build rk3036 board and see if can reproduce
> >> this error?
> >> >
> >  The rk3036 (evb-rk3036_defconfig) builds fine (with my old 4.8
> > gcc).
> >
> > However, your patches cause other issues [1]:
> > https://travis-ci.org/lmajewski/u-boot-dfu/jobs/248264628
> >
> > And for example I can reproduce the issue on
> > rock2_defconfig at my local PC.
> >
> > Can you build rock2 on your PC with your patches applied without any
> > issues?
> I reproduced and fixed this issue long time ago. I didn't send my
> next version because i don't know how to reproduce 3036 issue. It
> looks like 3036 work fine on your side now. Can i ignore this 3036
> issue?

Please before posting next version make sure that no build breaks
shows up in TravisCI.

Please as a reference use mainline .travis.yml. (especially build for
rockchip)

Please let me know if you need any assistance at fixing problems.

> >
> >
> >
> >
> >
> > [1] The "testing" tree can be found at:
> > https://github.com/lmajewski/u-boot-dfu/tree/testing
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang
> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> > wd at denx.de




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de