public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Gautam Bhat <mindentropy@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/1] mx7sabresd: Set VLD04 output to 2.8V in PMIC initialization.
Date: Sat,  1 Jul 2017 12:26:28 +0530	[thread overview]
Message-ID: <20170701065628.6853-2-mindentropy@gmail.com> (raw)
In-Reply-To: <20170701065628.6853-1-mindentropy@gmail.com>

This change sets the VLDO4 settings output to 2.8V in PMIC
initialization so that the MIPI DSI/CSI input voltage is 2.8V
as per the schematics. The original code provides an output of
3.3V which violates the voltage mentioned in the schematics.

Acked-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
---

Changes in v2:
- Removed extra parentheses for 0xF.
- Modified subject and commit messages as per the recommendation.

 board/freescale/mx7dsabresd/mx7dsabresd.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c
index ecea5a529a..c9ff2d8e40 100644
--- a/board/freescale/mx7dsabresd/mx7dsabresd.c
+++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
@@ -341,6 +341,7 @@ int power_init_board(void)
 {
 	struct udevice *dev;
 	int ret, dev_id, rev_id;
+	uint regval;
 
 	ret = pmic_get("pfuze3000", &dev);
 	if (ret == -ENODEV)
@@ -354,6 +355,15 @@ int power_init_board(void)
 
 	pmic_clrsetbits(dev, PFUZE3000_LDOGCTL, 0, 1);
 
+	/*
+	 * Set the voltage of VLDO4 output to 2.8V which feeds
+	 * the MIPI DSI and MIPI CSI inputs.
+	 */
+	regval = pmic_reg_read(dev, PFUZE3000_VLD4CTL);
+	regval &= ~0xF;
+	regval |= 0xA; /* Set to 2.8V */
+	pmic_reg_write(dev, PFUZE3000_VLD4CTL, regval);
+
 	return 0;
 }
 #endif
-- 
2.11.0

  reply	other threads:[~2017-07-01  6:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-01  6:56 [U-Boot] [PATCH v2 0/1] mx7sabresd: Set VLD04 output to 2.8V in PMIC initialization Gautam Bhat
2017-07-01  6:56 ` Gautam Bhat [this message]
2017-07-01 15:18   ` [U-Boot] [PATCH v2 1/1] " Fabio Estevam
2017-07-02 19:20     ` [U-Boot] [PATCH v3 0/1] mx7dsabresd: " Gautam Bhat
2017-07-02 19:20       ` [U-Boot] [PATCH v3 1/1] " Gautam Bhat
2017-07-02 22:09         ` Fabio Estevam
2017-07-05  9:57           ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170701065628.6853-2-mindentropy@gmail.com \
    --to=mindentropy@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox