U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 11/15] dm: sunxi: Linksprite_pcDuino3: Correct polarity of MMC card detect
Date: Wed, 5 Jul 2017 16:43:59 +0200	[thread overview]
Message-ID: <20170705144359.ncqefgcf7sd5vyjk@flea> (raw)
In-Reply-To: <20170704193133.87092-12-sjg@chromium.org>

Hi,

On Tue, Jul 04, 2017 at 01:31:28PM -0600, Simon Glass wrote:
> This is shown as active high in the schematics[1], so fix it.
> 
> [1] https://patchwork.ozlabs.org/patch/777890/
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reported-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> 
> Changes in v2:
> - Add new patch to correct polarity of MMC card detect on Linksprite_pcDuino3
> 
>  arch/arm/dts/sun7i-a20-pcduino3.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/sun7i-a20-pcduino3.dts b/arch/arm/dts/sun7i-a20-pcduino3.dts
> index 1a8b39be1d..37b1e0ee9b 100644
> --- a/arch/arm/dts/sun7i-a20-pcduino3.dts
> +++ b/arch/arm/dts/sun7i-a20-pcduino3.dts
> @@ -164,7 +164,7 @@
>  	pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_reference_design>;
>  	vmmc-supply = <&reg_vcc3v3>;
>  	bus-width = <4>;
> -	cd-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH1 */
> +	cd-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>; /* PH1 */

Hmmm, are you sure? At least your commit log says otherwise :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170705/6329bd8a/attachment.sig>

  reply	other threads:[~2017-07-05 14:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170704193156epcas1p3d563db457e88afc7c4c2baa9b42e3f40@epcas1p3.samsung.com>
2017-07-04 19:31 ` [U-Boot] [PATCH v2 00/15] dm: sata: mmc: Convert a sunxi board to driver model for MMC, SATA Simon Glass
2017-07-04 19:31   ` [U-Boot] [PATCH v2 01/15] ahci: Support non-PCI controllers Simon Glass
2017-07-04 19:31   ` [U-Boot] [PATCH v2 02/15] dm: mmc: Allow disabling driver model in SPL Simon Glass
2017-07-06 14:55     ` Jean-Jacques Hiblot
2017-07-13 19:09       ` Simon Glass
2017-07-04 19:31   ` [U-Boot] [PATCH v2 03/15] fdt: Correct fdt_get_base_address() Simon Glass
2017-07-04 19:31   ` [U-Boot] [PATCH v2 04/15] dm: scsi: Drop duplicate SCSI and DM_SCSI options Simon Glass
2017-07-04 19:31   ` [U-Boot] [PATCH v2 05/15] dm: ahci: Correct uclass private data Simon Glass
2017-07-04 19:31   ` [U-Boot] [PATCH v2 06/15] dm: mmc: sunxi: Rename struct sunxi_mmc_host to sunxi_mmc_priv Simon Glass
2017-07-05 14:35     ` Maxime Ripard
2017-07-04 19:31   ` [U-Boot] [PATCH v2 07/15] dm: mmc: sunxi: Rename mmchost to priv Simon Glass
2017-07-05 14:35     ` Maxime Ripard
2017-07-04 19:31   ` [U-Boot] [PATCH v2 08/15] dm: mmc: sunxi: Pass private data around explicitly Simon Glass
2017-07-05 14:36     ` Maxime Ripard
2017-08-09  3:27     ` Chen-Yu Tsai
2017-08-14 21:35       ` Simon Glass
2017-08-24  3:12         ` Chen-Yu Tsai
2017-07-04 19:31   ` [U-Boot] [PATCH v2 09/15] dm: mmc: sunxi: Drop mmc_clk_io_on() Simon Glass
2017-07-05 14:42     ` Maxime Ripard
2017-07-04 19:31   ` [U-Boot] [PATCH v2 10/15] dm: mmc: sunxi: Add support for driver model Simon Glass
2018-01-31 17:08     ` [U-Boot] [U-Boot, v2, " Heinrich Schuchardt
2018-02-01 15:11       ` Tuomas Tynkkynen
2018-02-01 15:26         ` Heinrich Schuchardt
2017-07-04 19:31   ` [U-Boot] [PATCH v2 11/15] dm: sunxi: Linksprite_pcDuino3: Correct polarity of MMC card detect Simon Glass
2017-07-05 14:43     ` Maxime Ripard [this message]
2017-08-04 23:14       ` Simon Glass
2017-07-04 19:31   ` [U-Boot] [PATCH v2 12/15] dm: scsi: Don't scan the SCSI bus when probing Simon Glass
2017-07-23  4:42     ` Bin Meng
2017-07-28  4:20       ` Simon Glass
2017-07-04 19:31   ` [U-Boot] [PATCH v2 13/15] dm: sunxi: sata: Don't build sata support into SPL Simon Glass
2017-07-05 14:44     ` Maxime Ripard
2017-07-04 19:31   ` [U-Boot] [PATCH v2 14/15] dm: sata: sunxi: Add support for driver model Simon Glass
2017-07-05 14:44     ` Maxime Ripard
2017-07-04 19:31   ` [U-Boot] [PATCH v2 15/15] dm: sunxi: Move Linksprite_pcDuino3 to use DM for MMC, SATA Simon Glass
2017-07-28 12:27   ` [U-Boot] [PATCH v2 00/15] dm: sata: mmc: Convert a sunxi board to driver model " Jaehoon Chung
2017-08-18 19:31     ` Peter Robinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170705144359.ncqefgcf7sd5vyjk@flea \
    --to=maxime.ripard@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox