From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 2/3] wdt: Timeout better to be in microseconds
Date: Wed, 5 Jul 2017 20:44:07 +0300 [thread overview]
Message-ID: <20170705174408.72891-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20170705174408.72891-1-andriy.shevchenko@linux.intel.com>
Timeout in some abstract ticks is not what we are applying to get
deterministic behaviour.
Convert name to show explicitly that we are using microseconds (for
watchdog it's more than precise).
No functional change intended.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/watchdog/wdt-uclass.c | 4 ++--
include/wdt.h | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/watchdog/wdt-uclass.c b/drivers/watchdog/wdt-uclass.c
index bb9ae80866..1715a98452 100644
--- a/drivers/watchdog/wdt-uclass.c
+++ b/drivers/watchdog/wdt-uclass.c
@@ -13,14 +13,14 @@
DECLARE_GLOBAL_DATA_PTR;
-int wdt_start(struct udevice *dev, u64 timeout, ulong flags)
+int wdt_start(struct udevice *dev, u64 timeout_us, ulong flags)
{
const struct wdt_ops *ops = device_get_ops(dev);
if (!ops->start)
return -ENOSYS;
- return ops->start(dev, timeout, flags);
+ return ops->start(dev, timeout_us, flags);
}
int wdt_stop(struct udevice *dev)
diff --git a/include/wdt.h b/include/wdt.h
index 0b5f05851a..115e8c6baf 100644
--- a/include/wdt.h
+++ b/include/wdt.h
@@ -21,12 +21,12 @@
* Start the timer
*
* @dev: WDT Device
- * @timeout: Number of ticks before timer expires
+ * @timeout_us: Number of microseconds before timer expires
* @flags: Driver specific flags. This might be used to specify
* which action needs to be executed when the timer expires
* @return: 0 if OK, -ve on error
*/
-int wdt_start(struct udevice *dev, u64 timeout, ulong flags);
+int wdt_start(struct udevice *dev, u64 timeout_us, ulong flags);
/*
* Stop the timer, thus disabling the Watchdog. Use wdt_start to start it again.
@@ -67,12 +67,12 @@ struct wdt_ops {
* Start the timer
*
* @dev: WDT Device
- * @timeout: Number of ticks before the timer expires
+ * @timeout_us: Number of microseconds before the timer expires
* @flags: Driver specific flags. This might be used to specify
* which action needs to be executed when the timer expires
* @return: 0 if OK, -ve on error
*/
- int (*start)(struct udevice *dev, u64 timeout, ulong flags);
+ int (*start)(struct udevice *dev, u64 timeout_us, ulong flags);
/*
* Stop the timer
*
--
2.11.0
next prev parent reply other threads:[~2017-07-05 17:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 17:44 [U-Boot] [PATCH v1 1/3] wdt: Fix spelling Resettting -> Resetting Andy Shevchenko
2017-07-05 17:44 ` Andy Shevchenko [this message]
2017-07-06 4:16 ` [U-Boot] [PATCH v1 2/3] wdt: Timeout better to be in microseconds Bin Meng
2017-07-06 4:34 ` Heiko Schocher
2017-07-07 3:59 ` Simon Glass
2017-07-07 11:15 ` Andy Shevchenko
2017-07-05 17:44 ` [U-Boot] [PATCH v1 3/3] wdt: Unify option of timeout value Andy Shevchenko
2017-07-05 17:50 ` Andy Shevchenko
2017-07-06 4:16 ` Bin Meng
2017-07-06 6:07 ` Heiko Schocher
2017-07-07 3:59 ` Simon Glass
2017-07-07 11:42 ` [U-Boot] [U-Boot,v1,3/3] " Tom Rini
2017-07-06 4:15 ` [U-Boot] [PATCH v1 1/3] wdt: Fix spelling Resettting -> Resetting Bin Meng
2017-07-06 4:29 ` Heiko Schocher
2017-07-07 3:59 ` Simon Glass
2017-07-07 11:42 ` [U-Boot] [U-Boot, v1, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705174408.72891-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox