From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lothar =?UTF-8?B?V2HDn21hbm4=?= <LW@KARO-electronics.de>
Date: Thu, 6 Jul 2017 09:50:37 +0200
Subject: [U-Boot] [PATCH] dm: video: fix abuse of enum
In-Reply-To: <CAPnjgZ0e-ee_qG8pc3AASgt=RSM+3vQQPzgkwAMR_FLY_zYAzA@mail.gmail.com>
References: <1497954329-13384-1-git-send-email-LW@KARO-electronics.de>
 <CAPnjgZ3VCcNpP_Ww1OiZL9zn312JN62JWZVqCwuFk9HWo3u5rQ@mail.gmail.com>
 <20170621095905.0fa0fb0c@karo-electronics.de>
 <20170623083001.45087ce1@karo-electronics.de>
 <CAPnjgZ0e-ee_qG8pc3AASgt=RSM+3vQQPzgkwAMR_FLY_zYAzA@mail.gmail.com>
Message-ID: <20170706095037.20bbb03c@karo-electronics.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

Hi,

On Wed, 5 Jul 2017 22:49:28 -0600 Simon Glass wrote:
> Hi Lothar,
> 
> On 23 June 2017 at 00:30, Lothar Waßmann <LW@karo-electronics.de> wrote:
> > Hi,
> >
> > On Wed, 21 Jun 2017 09:59:05 +0200 Lothar Waßmann wrote:
> >> Hi,
> >>
> >> On Tue, 20 Jun 2017 12:26:29 -0600 Simon Glass wrote:
> >> > Hi Lothar,
> >> >
> >> > On 20 June 2017 at 04:25, Lothar Waßmann <LW@karo-electronics.de> wrote:
> >> > > LCD_MAX_WIDTH, LCD_MAX_HEIGHT and LCD_MAX_LSBPP are not alternative
> >> > > values for one specific variable, but unrelated entities with distinct
> >> > > purposes. There is no use defining them as values of an 'enum'.
> >> >
> >> > Can you explain why #define is better? I prefer enum since they are a
> >> > compiler construct instead of preprocessor (thus no need for brackets,
> >> > no strange conversion things) and the debugger knows about them.
> >> >
> >> An enum defines alternative values for one specific entity (e.g.
> >> clauses for a switch construct), but not a collection of arbitrary data
> >> items.
> >>
> >> > > The 'enum' construct would fail miserably for an LCD controller that
> >> > > has a square max. frame size (e.g. 4096x4096).
> >> >
> >> > What does this mean? I don't understand sorry.
> >> >
> >> Try your enum with MAX_LCD_WITDH == MAC_LCD_HEIGHT.
> 
> Can you please be explicit as to what the problem is? Sorry but I
> don't understand what you are driving at. Do you have a test program
> which shows the problem?
> 
You cannot have two different enum items with the same value!
Thus:
enum {
	MAX_LCD_WIDTH = 4096,
	MAX_LCD_HEIGHT = 4096,
};
won't compile.


The purpose of an enum is to provide a collection of possible values
that can be taken by a single variable. E.g. enumerate the states of a
state machine, video modes, CPU types...
It's not meant to group together otherwise unsolicited values.


Lothar Waßmann