From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 10 Jul 2017 22:08:09 +0200 Subject: [U-Boot] [PATCH 28/30] env: Drop saveenv() in favour of env_save() In-Reply-To: <20170709205313.116174-29-sjg@chromium.org> References: <20170709205313.116174-1-sjg@chromium.org> <20170709205313.116174-29-sjg@chromium.org> Message-ID: <20170710200809.7EEE4120D15@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Simon, In message <20170709205313.116174-29-sjg@chromium.org> you wrote: > Use the env_save() function directly now that there is only one > implementation of saveenv(). ... > printf("Setting reboot to fastboot flag ...\n"); > setenv("dofastboot", "1"); > - saveenv(); > + env_save(); Hm... the old name saveenv() was once derived from the command line command with the same name, in the same way as setenv() is/was. One can argument that your new name env_save( corresponds to the more modern "env " syntax - but should we then not also rename setenv() into env_set() , so we use a consistent naming scheme again? Reviewed-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de He'd heard her use that sweet, innocent tone of voice before. It meant that, pretty soon, there was going to be trouble. - Terry Pratchett, _Truckers_