From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lothar =?UTF-8?B?V2HDn21hbm4=?= <LW@KARO-electronics.de>
Date: Wed, 12 Jul 2017 13:44:58 +0200
Subject: [U-Boot] Warning due to commit 6a516ef15d79
In-Reply-To: <71d4ac8d-00e4-9ff9-ff00-37ec46d80856@denx.de>
References: <71d4ac8d-00e4-9ff9-ff00-37ec46d80856@denx.de>
Message-ID: <20170712134458.376460fd@karo-electronics.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

Hi Stefano,

On Wed, 12 Jul 2017 10:45:21 +0200 Stefano Babic wrote:
> Hi Lothar,
> 
> your recent patch :
> 
> commit 306dd7dabd6472b8b66ab5106d5a6a516ef15d79
> Author: Lothar Waßmann <LW@KARO-electronics.de>
> Date:   Tue Jun 27 15:23:16 2017 +0200
> 
>     net: fec_mxc: fix PHY initialization bug with CONFIG_DM_ETH
> 
> 
> is cause of warnings in several i.MX boards, such as:
> 
>        arm:  +   imx6ul_geam_nand
> +  struct udevice *vqmmc_dev;
> +                  ^
> +  bus = fec_get_miibus(dev, dev_id);
> +                       ^
> +drivers/net/fec_mxc.c:988:17: note: expected 'uint32_t {aka unsigned
> int}' but argument is of type 'struct udevice *'
> + struct mii_dev *fec_get_miibus(uint32_t base_addr, int dev_id)
> +                 ^
> 
> In fact, dev is a udevice and not an int as the prototype for
> fec_get_miibus(). Could you take a look, please ? Thanks !
> 
Should I resend a corrected version, or a fixup on top of this patch?


Lothar Waßmann