public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed
Date: Mon, 17 Jul 2017 22:35:28 -0400	[thread overview]
Message-ID: <20170718023528.GF14320@bill-the-cat> (raw)
In-Reply-To: <20170717092939.lm3mqbi5xpgpyrzi@flea>

On Mon, Jul 17, 2017 at 11:29:39AM +0200, Maxime Ripard wrote:
> On Wed, Jul 12, 2017 at 04:37:43PM +0200, Dr. Philipp Tomsich wrote:
> > 
> > > On 12 Jul 2017, at 16:34, Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> > > 
> > > The -mno-unaligned-access flag used on ARM to prevent GCC from generating
> > > unaligned accesses (obviously) will only do so on packed structures.
> > > 
> > > It seems like gcc 7.1 is a bit stricter than previous gcc versions on this,
> > > and using it lead to data abort for unaligned accesses when generating
> > > network traffic.
> > > 
> > > Fix this by adding the packed attribute to the ip_udp_hdr structure in
> > > order to let GCC do its job.
> > > 
> > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > > —
> > 
> > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> 
> I'm not exactly sure who is supposed to merge patches touching
> include/ ? Tom?

I'd like Joe to chime in, since it's net related.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170717/8e52121a/attachment.sig>

  reply	other threads:[~2017-07-18  2:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12 14:34 [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed Maxime Ripard
2017-07-12 14:37 ` Dr. Philipp Tomsich
2017-07-17  9:29   ` Maxime Ripard
2017-07-18  2:35     ` Tom Rini [this message]
2017-07-21 19:15 ` Siarhei Siamashka
2017-07-21 19:37   ` Siarhei Siamashka
  -- strict thread matches above, loose matches on Subject: below --
2017-07-12 14:34 Maxime Ripard
2017-07-18 18:10 ` Joe Hershberger
2017-07-19  7:01   ` Maxime Ripard
2017-07-19 18:13     ` Joe Hershberger
2017-07-19 18:26   ` Jeroen Hofstee
2017-07-21 18:46     ` Siarhei Siamashka
2017-07-22 13:32       ` Jeroen Hofstee
2017-07-19 18:14 ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718023528.GF14320@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox