From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 17 Jul 2017 22:35:28 -0400 Subject: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed In-Reply-To: <20170717092939.lm3mqbi5xpgpyrzi@flea> References: <20170712143450.12233-1-maxime.ripard@free-electrons.com> <20170717092939.lm3mqbi5xpgpyrzi@flea> Message-ID: <20170718023528.GF14320@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de On Mon, Jul 17, 2017 at 11:29:39AM +0200, Maxime Ripard wrote: > On Wed, Jul 12, 2017 at 04:37:43PM +0200, Dr. Philipp Tomsich wrote: > >=20 > > > On 12 Jul 2017, at 16:34, Maxime Ripard wrote: > > >=20 > > > The -mno-unaligned-access flag used on ARM to prevent GCC from genera= ting > > > unaligned accesses (obviously) will only do so on packed structures. > > >=20 > > > It seems like gcc 7.1 is a bit stricter than previous gcc versions on= this, > > > and using it lead to data abort for unaligned accesses when generating > > > network traffic. > > >=20 > > > Fix this by adding the packed attribute to the ip_udp_hdr structure in > > > order to let GCC do its job. > > >=20 > > > Signed-off-by: Maxime Ripard > > > =E2=80=94 > >=20 > > Reviewed-by: Philipp Tomsich >=20 > I'm not exactly sure who is supposed to merge patches touching > include/ ? Tom? I'd like Joe to chime in, since it's net related. --=20 Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: