From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: mach-keystone: Fixes issue with return values in inline assembly
Date: Tue, 18 Jul 2017 13:08:44 -0400 [thread overview]
Message-ID: <20170718170844.GW14320@bill-the-cat> (raw)
In-Reply-To: <20170717180202.13072-1-afd@ti.com>
On Mon, Jul 17, 2017 at 01:02:02PM -0500, Andrew F. Davis wrote:
> From: "Srinivas, Madan" <madans@ti.com>
>
> The inline assembly functions in mon.c assume that the caller will
> check for the return value in r0 according to regular ARM calling
> conventions.
>
> However, this assumption breaks down if the compiler inlines the
> functions. The caller is then under no obligation to use r0 for the
> result.
>
> To fix this disconnect, we must explicitly move the return value
> from the smc/bl call to the variable that the function returns.
>
> Signed-off-by: Madan Srinivas <madans@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170718/21b724e4/attachment.sig>
next prev parent reply other threads:[~2017-07-18 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 18:02 [U-Boot] [PATCH] arm: mach-keystone: Fixes issue with return values in inline assembly Andrew F. Davis
2017-07-18 17:08 ` Tom Rini [this message]
2017-07-26 19:50 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718170844.GW14320@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox