* [U-Boot] [PATCH] efi_loader: add some missing breaks
@ 2017-07-27 15:28 Rob Clark
2017-07-28 10:58 ` Heinrich Schuchardt
2017-07-28 22:28 ` [U-Boot] " Alexander Graf
0 siblings, 2 replies; 3+ messages in thread
From: Rob Clark @ 2017-07-27 15:28 UTC (permalink / raw)
To: u-boot
Signed-off-by: Rob Clark <robdclark@gmail.com>
---
Just noticed that there didn't seem to be quite enough break's. Pretty
sure the intention wasn't to fall-thru
lib/efi_loader/efi_device_path_to_text.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c
index 612e380617..4b2f43f0c8 100644
--- a/lib/efi_loader/efi_device_path_to_text.c
+++ b/lib/efi_loader/efi_device_path_to_text.c
@@ -52,6 +52,7 @@ static uint16_t *efi_convert_device_node_to_text(
break;
}
}
+ break;
case DEVICE_PATH_TYPE_MEDIA_DEVICE:
switch (device_node->sub_type) {
case DEVICE_PATH_SUB_TYPE_FILE_PATH:
@@ -63,6 +64,7 @@ static uint16_t *efi_convert_device_node_to_text(
memcpy(buffer, device_node->data, buffer_size);
break;
}
+ break;
}
/*
--
2.13.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] efi_loader: add some missing breaks
2017-07-27 15:28 [U-Boot] [PATCH] efi_loader: add some missing breaks Rob Clark
@ 2017-07-28 10:58 ` Heinrich Schuchardt
2017-07-28 22:28 ` [U-Boot] " Alexander Graf
1 sibling, 0 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2017-07-28 10:58 UTC (permalink / raw)
To: u-boot
On 07/27/2017 05:28 PM, Rob Clark wrote:
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
> Just noticed that there didn't seem to be quite enough break's. Pretty
> sure the intention wasn't to fall-thru
>
> lib/efi_loader/efi_device_path_to_text.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c
> index 612e380617..4b2f43f0c8 100644
> --- a/lib/efi_loader/efi_device_path_to_text.c
> +++ b/lib/efi_loader/efi_device_path_to_text.c
> @@ -52,6 +52,7 @@ static uint16_t *efi_convert_device_node_to_text(
> break;
> }
> }
> + break;
> case DEVICE_PATH_TYPE_MEDIA_DEVICE:
> switch (device_node->sub_type) {
> case DEVICE_PATH_SUB_TYPE_FILE_PATH:
> @@ -63,6 +64,7 @@ static uint16_t *efi_convert_device_node_to_text(
> memcpy(buffer, device_node->data, buffer_size);
> break;
> }
> + break;
> }
>
> /*
>
Thank you for catching this.
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] efi_loader: add some missing breaks
2017-07-27 15:28 [U-Boot] [PATCH] efi_loader: add some missing breaks Rob Clark
2017-07-28 10:58 ` Heinrich Schuchardt
@ 2017-07-28 22:28 ` Alexander Graf
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Graf @ 2017-07-28 22:28 UTC (permalink / raw)
To: u-boot
> Signed-off-by: Rob Clark <robdclark@gmail.com>
Thanks, applied to efi-next
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-28 22:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-27 15:28 [U-Boot] [PATCH] efi_loader: add some missing breaks Rob Clark
2017-07-28 10:58 ` Heinrich Schuchardt
2017-07-28 22:28 ` [U-Boot] " Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox