From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Wed, 2 Aug 2017 12:24:27 +0200 Subject: [U-Boot] [PATCH] imx6: fix SDn_CMD mux mode bitfield arguments In-Reply-To: References: <1501593279-24282-1-git-send-email-agust@denx.de> Message-ID: <20170802122427.559fc07c@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, On Wed, 2 Aug 2017 11:24:22 +0200 Stefano Babic sbabic at denx.de wrote: ... > > -MX6_PAD_DECL(SD2_CMD__SD2_CMD, 0x0740, 0x0358, 16, 0x0000, 0, 0) > > +MX6_PAD_DECL(SD2_CMD__SD2_CMD, 0x0740, 0x0358, 0, 0x0000, 0, 0) ... > > The MUX mode is not changed, but 16 means that the SION bit is set. This > forces the MUX to ALT0. I have no idea why the SION bit is set for SD, > but we have already had some cases with ENET (and GIPOs require to set > SION as well). In any case, if SION must be set, it should be not done > with the value (16), but with the macro IOMUX_CONFIG_SION. SD_CMD is bi-directional and SION setting seems to be intended here. OK, I'll resubmit with IOMUX_CONFIG_SION to make it clear. Thanks, Anatolij