From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Wed, 2 Aug 2017 17:32:10 +0200 Subject: [U-Boot] [PATCH] imx-common: spl: return boot mode for asked MMC device in spl_boot_mode() In-Reply-To: References: <1501593834-24510-1-git-send-email-agust@denx.de> Message-ID: <20170802173210.6dce3eef@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, On Wed, 2 Aug 2017 11:54:24 +0200 Stefano Babic sbabic at denx.de wrote: ... > > +++ b/arch/arm/mach-imx/spl.c > > @@ -84,7 +84,7 @@ u32 spl_boot_device(void) > > /* called from spl_mmc to see type of boot mode for storage (RAW or FAT) */ > > u32 spl_boot_mode(const u32 boot_device) > > { > > - switch (spl_boot_device()) { > > + switch (boot_device) { > > /* for MMC return either RAW or FAT mode */ > > case BOOT_DEVICE_MMC1: > > case BOOT_DEVICE_MMC2: > > > > Nevertheless it seems difficult to be consistent. Let's start with the > case where a on-board device (SPI or eMMC) does not boot, and the way to > save the board is to boot from an external board. And SPL on the onboard > flash is damaged, but not u-boot.img. Anyway, we want that the board > boots with its consistent status, that is with the pair SPL+u-boot.img. > In the example I tracked, both from the SD card. This is consistent > using spl_boot_device, because it does not try to boot from a different > device as the one where SPL was loaded. thanks for explanation, I'll have to find another way then, or will maintain this patch out of tree. -- Anatolij