From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] scripts: setlocalversion: safely extract variables from auto.conf using awk
Date: Wed, 9 Aug 2017 21:42:16 -0400 [thread overview]
Message-ID: <20170810014216.GI5837@bill-the-cat> (raw)
In-Reply-To: <1502199423-57703-1-git-send-email-philipp.tomsich@theobroma-systems.com>
On Tue, Aug 08, 2017 at 03:37:03PM +0200, Philipp Tomsich wrote:
> Moving SPL_LDSCRIPT to Kconfig triggered an unfortunate attempt of
> command substitution, as the sourced auto.conf may include $(ARCH)
> which tries to execute a command 'ARCH'.
> This showed up as a warning similar to the following:
> include/config/auto.conf: line 209: ARCH: command not found
>
> This change does no longer attempt to source auto.conf, but rather
> passes it through awk to retrieve the values for CONFIG_LOCALVERSION
> and CONFIG_LOCALVERSION_AUTO. This will also mitigate the risk of
> unintended command substitution.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reported-by: Andy Yan <andy.yan@rock-chips.com>
>
Reviewed-by: Tom Rini <trini@konsulko.com>
I do wonder if we can get this into the kernel as well.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170809/aadf262c/attachment.sig>
next prev parent reply other threads:[~2017-08-10 1:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 13:37 [U-Boot] [PATCH] scripts: setlocalversion: safely extract variables from auto.conf using awk Philipp Tomsich
2017-08-10 1:42 ` Tom Rini [this message]
2017-08-10 10:29 ` [U-Boot] " Philipp Tomsich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810014216.GI5837@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox