From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 9 Aug 2017 21:42:16 -0400 Subject: [U-Boot] [PATCH] scripts: setlocalversion: safely extract variables from auto.conf using awk In-Reply-To: <1502199423-57703-1-git-send-email-philipp.tomsich@theobroma-systems.com> References: <1502199423-57703-1-git-send-email-philipp.tomsich@theobroma-systems.com> Message-ID: <20170810014216.GI5837@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Aug 08, 2017 at 03:37:03PM +0200, Philipp Tomsich wrote: > Moving SPL_LDSCRIPT to Kconfig triggered an unfortunate attempt of > command substitution, as the sourced auto.conf may include $(ARCH) > which tries to execute a command 'ARCH'. > This showed up as a warning similar to the following: > include/config/auto.conf: line 209: ARCH: command not found > > This change does no longer attempt to source auto.conf, but rather > passes it through awk to retrieve the values for CONFIG_LOCALVERSION > and CONFIG_LOCALVERSION_AUTO. This will also mitigate the risk of > unintended command substitution. > > Signed-off-by: Philipp Tomsich > Reported-by: Andy Yan > Reviewed-by: Tom Rini I do wonder if we can get this into the kernel as well. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: