From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] arch/sh: don't bring common/env_embedded.o into the link
Date: Tue, 15 Aug 2017 22:54:33 +0200 [thread overview]
Message-ID: <20170815225433.6cb1d5f5@windsurf> (raw)
In-Reply-To: <CABMQnVL6UXPis+s243-jtbLd5hQcqEGvXhdwjZrRJxSnrV6wew@mail.gmail.com>
Hello,
On Thu, 3 Aug 2017 08:20:20 +0900, Nobuhiro Iwamatsu wrote:
> Hi,
>
> 2017-07-29 6:46 GMT+09:00 Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com>:
> > The linker script for SuperH brings the .ppcenv and .ppcenvr section
> > of common/env_embedded.o into the .text section. However, the .ppcenv
> > section is only ever filled in by env_embedded.o when
> > CONFIG_SYS_USE_PPCENV is defined, but no platforms in mainline U-Boot
> > use this.
> >
> > In addition, common/env_embedded.o is not always built (when you use
> > CONFIG_ENV_IS_NOWHERE for example), which causes the following build
> > failure:
> >
> > Fixes:
> >
> > LD u-boot
> > /home/thomas/sh4aeb-linux-musl/bin/sh4aeb-linux-ld.bfd: cannot find common/env_embedded.o
> >
> > We fix this by no longer adding the .ppcenv and .ppcenvr sections from
> > common/env_embedded.o into the .text section.
> >
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> Acked-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Thanks for your review! Are you going to apply the patch, as you did
for "arch/sh: allow building in big-endian mode" ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-15 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 21:46 [U-Boot] [PATCH 0/3] env_embedded related fixes/improvements Thomas Petazzoni
2017-07-28 21:46 ` [U-Boot] [PATCH 1/3] arch/sh: don't bring common/env_embedded.o into the link Thomas Petazzoni
2017-08-02 23:20 ` Nobuhiro Iwamatsu
2017-08-15 20:54 ` Thomas Petazzoni [this message]
2017-07-28 21:46 ` [U-Boot] [PATCH 2/3] common/env_embedded.c: drop support for CONFIG_SYS_USE_PPCENV Thomas Petazzoni
2017-08-07 13:57 ` [U-Boot] [U-Boot, " Tom Rini
2017-07-28 21:46 ` [U-Boot] [PATCH 3/3] common/env_embedded.c: rename PPCENV/PPCTEXT macros Thomas Petazzoni
2017-08-07 13:57 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815225433.6cb1d5f5@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox